adding h_nelec_sed and h_e_sed to SRTrueCaloPoint for better recombination studies#182
adding h_nelec_sed and h_e_sed to SRTrueCaloPoint for better recombination studies#182sungbinoh wants to merge 2 commits intoSBNSoftware:developfrom
Conversation
henrylay97
left a comment
There was a problem hiding this comment.
Looks worth doing, thanks Sungbin!
One tiny comment about typos :)
I'll wait until the PR is not-draft to approve, I assume there are complementary PRs coming in other repositories?
| float h_nelec_sed; //!< number of electrons from simEnergyDeposit (sed) in wire z +- (wire spacig) / 2, for sed overlapping with the boarder, overlaping fraction is multiplied | ||
| float h_e_sed; //!< deposited energy [MeV] from simEnergyDeposit (sed) in wire z +- (wire spacig) / 2, for sed overlapping with the boarder, overlaping fraction is multiplied |
There was a problem hiding this comment.
Couple of typos in the comments: spacig-->spacing and boarder-->border
Hi @henrylay97 , thank you for the review. I've fixed the typos! I have a working version of sbncode (link) for the new variables but it works only for SBND. |
Quick checklist
git fetchand pulled the latest changes from the branch you're basing your PR against?ClassVersionby one compared to develop in classes_def.xml?Description
Adding h_nelec_sed and h_e_sed to SRTrueCaloPoint for better recombination studies.
These variables will save deposited energy and number of ionizing electrons collected from simEnergyDeposit within wire channel position +- spacing/2. They correspond to the true deposited energy and number of ionizing electrons in the hit pitch.