Skip to content

SBND Timing Reconstruction Refactor#188

Open
VCLanNguyen wants to merge 3 commits intodevelopfrom
feature/frame_shift_refactor_v10_00_14
Open

SBND Timing Reconstruction Refactor#188
VCLanNguyen wants to merge 3 commits intodevelopfrom
feature/frame_shift_refactor_v10_00_14

Conversation

@VCLanNguyen
Copy link
Contributor

@VCLanNguyen VCLanNguyen commented Mar 4, 2026

Description

  • Timing reconstruction is refactored in this PR, affecting the decode/reconstruction workflow of CRT/PMT/XA.
  • After the refactoring, the @FrameShiftModule@ runs first in the decode chain, outputs timing products to be used at PMT/XA decoder and CRTStrip reconstruction.
  • Relevant PMT reconstruction modules at Reco1/Reco2 are updated.
  • The timing correction applied at CAFMakeer is undone.
  • Details and validation plots can before in the linked docdb.

Link(s) to docdb describing changes (optional)

https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=45982

Relevant PR links (optional)

This PR needs the XA decoder PR in sbndcode to go in first:
SBNSoftware/sbndcode#847

This PR needs to be merged together with this group of PRs:

Quick checklist

  • Have you run git fetch and pulled the latest changes from the branch you're basing your PR against?
  • If you're adding new classes, have you added them to classes_def.xml in the relevant directory?
  • Have you added a checksum in classes_def.xml to any and all new classes you're implementing, and rebuilt?
  • If you're updating classes, have you incremented the ClassVersion by one compared to develop in classes_def.xml?

@VCLanNguyen VCLanNguyen changed the title Feature/frame shift refactor v10 00 14 SBND Timing Reconstruction Refactor Mar 4, 2026
@VCLanNguyen VCLanNguyen self-assigned this Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants