-
Notifications
You must be signed in to change notification settings - Fork 55
Light Calorimetry #878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lynnt20
wants to merge
91
commits into
develop
Choose a base branch
from
feature/lynnt_lightcalorimetry
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Light Calorimetry #878
Changes from 11 commits
Commits
Show all changes
91 commits
Select commit
Hold shift + click to select a range
94c59df
first build + commit
lynnt20 08bd042
added root tree, more explicit cut parameters, and opflashes
lynnt20 fa2b8a7
first commit of light reco attempt using visibility map
lynnt20 ccea7c6
working version with reco/true comparisons
lynnt20 afea365
added backtracker info
lynnt20 7ed0f0e
cleaned up trees, added wire assn, gamma weighted avg, true hit info
lynnt20 31847f3
clean up truth/reco hit information
lynnt20 b119273
add calibration constants for all planes
lynnt20 55032e6
use all hits instead of spacepoints->hits
lynnt20 fea4bf4
clean up calorimetry cmakelists
lynnt20 477b63a
calculate median as light estimate
lynnt20 eea4729
removed unweighted fcl, added arapucas and noise threshold
lynnt20 081f01d
fix tpc split bug, comitting debugging couts, add mean+median functions
lynnt20 91ad097
cleanup
lynnt20 2e972c0
cleanup: remove hardcoded values, add fcl params
lynnt20 ab13d13
Merge tag 'v09_67_00' into feature/lynnt_lightcalorimetry
lynnt20 5a0893c
added verbose + skip truth validation fcl
lynnt20 bd8b760
added verbose + skip truth validation fcl
lynnt20 bf0b0cc
initial commit of producer module
lynnt20 8411be8
working version of producer module
lynnt20 52c18df
cleanup, new functions, fcl parameters:
lynnt20 a1df52b
update output ttree, fix initialized/dummy ttree variables
lynnt20 d21b784
Merge tag 'v09_89_01' into feature/lynnt_lightcalorimetry
lynnt20 16ce241
switch to correct namespace for photon model, cleanup
lynnt20 b791b51
update opdet efficiencies and simulation values
lynnt20 543c337
make working version of fcl without the analyzer
lynnt20 2fc9be1
update noise/non-linearity thresholds
lynnt20 6b59f8e
small cleanup
lynnt20 07bdd70
Merge tag 'v09_93_01_02p02' into feature/lynnt_lightcalorimetry
lynnt20 37a8831
Merge tag 'v10_04_07' into feature/lynnt_lightcalorimetry
lynnt20 30cf079
update geometry service to compile with v10_04_07
lynnt20 22c27ad
intermediate commit for first lines that include opt0finder (compiles)
lynnt20 82222e3
update efficiency, visibility configs, and add channel mask
lynnt20 6ad380a
add fcl config to choose between flash matchers
lynnt20 c1dd670
fix bug with visibility/efficiency
lynnt20 dd10310
fcl syntax fix, adding `OpT0FinderProducer` value to fcl
lynnt20 c8561f8
add simple analyzer to scrape mc sim energy depo information after g4…
lynnt20 b83e549
add lightcalo ana only fcl
lynnt20 7ed0b0d
Merge tag 'v10_05_00' into feature/lynnt_lightcalorimetry
lynnt20 b2f560c
update running fcls
lynnt20 6a6a6f6
use vector instead of unordered set
lynnt20 b9e13a0
Merge tag 'v10_06_02' into feature/lynnt_lightcalorimetry
lynnt20 37d4683
Add pmt variations fcls
asanchezcastillo 6447cf1
add more feaetures to mccaloana
asanchezcastillo b27bf1a
add more features to lightcaloana
lynnt20 a149a0c
update producer module to be aligned with analyzer
lynnt20 f4a7206
add more features to mccalo, now assumes only ONE neutrino interactio…
lynnt20 4b05f10
Merge tag 'v10_11_01_01' into feature/lynnt_lightcalorimetry_dev
lynnt20 103c567
updates to calls for semi analytical model, now using optical path tool
lynnt20 8a9f255
Merge branch 'feature/lynnt_lightcalorimetry' into feature/lynnt_ligh…
lynnt20 81b6742
remove simpleflash, add barycenter fm, add template class for collect…
lynnt20 ad848b4
missing import of optical path fcl config
lynnt20 c789803
properly define tree/branches (it runs now!)
lynnt20 882af92
clean up some includes
lynnt20 f289952
move bulk of code into new function to allow easier returns, official…
lynnt20 536eaac
move accessing flash matching handles into their relevant scopes
lynnt20 4fc4108
remove unneeded modules
lynnt20 26e3199
remove unecessary branches, TTrees, and fix mean functions
lynnt20 0ecce33
fix median function (don't need to separate between tpcs...)
lynnt20 c3eccec
remove truth validation, keep fcl prefix consistent in variable names…
lynnt20 8ee9ff5
cleanup
lynnt20 7c5d380
add to workflow and add sce labels by default
lynnt20 5c36bc8
Merge tag 'v10_14_02' into feature/lynnt_lightcalorimetry
lynnt20 e8a12f8
remove unused variable, match lightcalo constructor to updated obj
lynnt20 923e0fe
update to latest TPC calibration constants, opdet efficiencies, and m…
lynnt20 367fe62
mask should contain both off pmts and not reconstructable pmts
lynnt20 03e277f
add sce lightcalo label to cafmakerjob
lynnt20 132c8df
temporarily disable blipreco
lynnt20 bb818e6
Update to larsoft v10_14_02_01
nathanielerowe 0613ae1
Merge branch 'release/v10_14_02_01'
nathanielerowe d10e1ae
get opflashes explicitly for slices that cross the cathode; light wei…
lynnt20 40f18b7
get opflashes explicitly for slices that cross the cathode; light wei…
lynnt20 017f9ee
lightcalo fcl organization
lynnt20 4c0ebe0
remove nuscore cut since we're not using it anyways
lynnt20 c67c53b
undo blip commenting out
lynnt20 297632a
use pmt calibration database instead of fcl param to identify on/reco…
lynnt20 6432861
update PMT efficiencies to latest, remove hardcoded off/non-reconstru…
lynnt20 193666b
Merge branch 'feature/lynnt_lightcalorimetry' into feature/lynnt_ligh…
lynnt20 7fe5bab
inherit efficiency, tpc constants from their initial fcls; add units …
lynnt20 8f48fed
checks opflash producer size instead of assuming both tpcs
lynnt20 18876a7
add fcl param on whether to fill TTree, add more comments, remove unu…
lynnt20 8dff5ed
cleanup unused includes and dependencies
lynnt20 916b861
add initial filename/timestamp info on the output art file
lynnt20 2e219b7
update LightCaloProducer to conditionally fill TTree and enhance logg…
lynnt20 2bfc1df
Revert "Update to larsoft v10_14_02"
lynnt20 eb1a3a9
Add electron lifetime database support to LightCaloProducer and updat…
lynnt20 68d3ab0
Merge tag 'v10_14_02_01' into feature/lynnt_lightcalorimetry
lynnt20 81a67e8
order matters for reco workflow includes!
lynnt20 d6b3270
update CMake dependences for TPC calibdb
lynnt20 1a5e851
fix some elifetime bugs
lynnt20 da3ae91
move electron lifetime retrieval to avoid duplication during slice loop
lynnt20 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynnt20 marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comment for all of us, and this can be punted to a separate PR. Should we have a single place where the fake "timestamp" is formed? So that when we inevitably end up changing the prescription in future we only have one point of maintenance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sungbinoh may have thoughts