[Production] Light yield detvar for gen2#923
[Production] Light yield detvar for gen2#923nathanielerowe merged 7 commits intoproduction/sbnd-gen2from
Conversation
|
Uhhhhh the high Eff one needs to scrub to G4 and modify the ScintPreScale. Working on it. |
are not saved and are not available in detvar flows
|
It still doesn't fix the highEff issue, but the lowEff one works, and is probably worth merging to get 1 PDS detvar going. |
|
trigger build ci_ref=v10_14_02_03 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_04 |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof - ignored failure for unit_test - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
So... I think this works fine for the highEff ones. Let's keep as is and merge. If anything we can fix in the future. |
|
@linyan-w Ok, it looks like this will cause issues based on all of the CI issues. If you still want to merge, I will default to what you want since it is a production branch, but be careful as it may cause problems down the line. |
|
For documentation purposes, here is the fcl level issue: |
|
The TVector3 issues were coming from blips. Those can be ignored. It seems like it ran fine, but just has issues with comparisons due to the change in data types. |
|
trigger build ci_ref=v10_14_02_03 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_04 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
Description
This is a PR for gen2 lightyield detvar (2 PDE changes).
This is intended for gen2 production.
Checklist
Reviewers,AssigneesDevelopementRelevant PR links (optional)
Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
No
Link(s) to docdb describing changes (optional)
Is there a docdb describing the issue this solves or the feature added?
To be added (Mar 26th)