Skip to content

Frame Shift Module to Correct Timing in Data - PR For Spring Production#141

Merged
kjplows merged 11 commits intorelease/SBN2025Afrom
lnguyen/frame_shift_pr_spring_production
Sep 5, 2025
Merged

Frame Shift Module to Correct Timing in Data - PR For Spring Production#141
kjplows merged 11 commits intorelease/SBN2025Afrom
lnguyen/frame_shift_pr_spring_production

Conversation

@VCLanNguyen
Copy link
Contributor

@VCLanNguyen VCLanNguyen commented Aug 30, 2025

Description can be found in docdb: https://sbn-docdb.fnal.gov/cgi-bin/sso/RetrieveFile?docid=43090

Required by the following PRs:
sbnobj 2025A: #141
sbnanaobj 2025A: SBNSoftware/sbnanaobj#155
sbndcode 2025A: SBNSoftware/sbndcode#803
sbncode 2025A: SBNSoftware/sbncode#563

Copy link
Member

@PetrilloAtWork PetrilloAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a lot of design comments for your consideration.

Despite the amount of comments, there is no heavy showstopper.
The requested changes are the removal of the destructors, and the cleaning of classes_def.xml.

VCLanNguyen and others added 7 commits September 2, 2025 07:20
Co-authored-by: Gianluca Petrillo <petrillo@slac.stanford.edu>
Co-authored-by: Gianluca Petrillo <petrillo@slac.stanford.edu>
Co-authored-by: Gianluca Petrillo <petrillo@slac.stanford.edu>
Co-authored-by: Gianluca Petrillo <petrillo@slac.stanford.edu>
…yles

Co-authored-by: Gianluca Petrillo <petrillo@slac.stanford.edu>
Copy link
Member

@PetrilloAtWork PetrilloAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change on a Doxygen comment header is still missing.

The rest is good.

@VCLanNguyen
Copy link
Contributor Author

One minor change on a Doxygen comment header is still missing.

The rest is good.

Added missing asterisk for Doxygen comment header

Copy link
Member

@PetrilloAtWork PetrilloAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!!

@kjplows
Copy link
Contributor

kjplows commented Sep 4, 2025

trigger build ci_ref=v10_06_02 LArSoft/larsoft@LARSOFT_SUITE_v10_06_00_02 LArSoft/larwirecell@LARSOFT_SUITE_v10_06_00_02 LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbn*@release/SBN2025A SBNSoftware/sbndcode@v10_06_03

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows merged commit 5f92f2c into release/SBN2025A Sep 5, 2025
3 of 6 checks passed
@kjplows kjplows moved this from Done to 2025 PRs in SBN software development Jan 16, 2026
@kjplows kjplows added this to the SBN2025A/v10_06_00_05 milestone Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change enhancement New feature or request

Projects

Status: Done
Status: 2025 PRs

Development

Successfully merging this pull request may close these issues.

5 participants