Feat: Implement password prompt as a standalone prompt#1353
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1353 +/- ##
==========================================
- Coverage 94.48% 94.48% -0.01%
==========================================
Files 51 51
Lines 4423 4457 +34
Branches 772 775 +3
==========================================
+ Hits 4179 4211 +32
- Misses 239 241 +2
Partials 5 5 ☔ View full report in Codecov by Sentry. |
SBoudrias
force-pushed
the
implement-standalone-password-prompt
branch
from
9964826 to
0d9eb82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted the core rewrite from #1334 (cc @matteosacchetto).
Since this other PR is blocked on finding the right key-binding, I want to unblock other work (like the theme branch) I punted upon to not heavily conflict with the rewrite. Separating the rewrite should reduce the friction 🤞🏻