Add optional support for vim and emac bindings #1838
Add optional support for vim and emac bindings #1838SBoudrias merged 11 commits intoSBoudrias:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1838 +/- ##
=======================================
Coverage ? 95.77%
=======================================
Files ? 45
Lines ? 2792
Branches ? 741
=======================================
Hits ? 2674
Misses ? 109
Partials ? 9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey 👋🏻 Thanks for the PR. Do you feel strongly about having those in Inquirer? It does still conflict with the search functionality in the select prompt. Personally I'm leaning towards not re-adding the feature at all. |
|
I am a vim user who tries for home row navigation wherever possible, so I'll probably stay on old version of I don't use the search functionality with the select prompt, and ended up downgrading, pinning, and bundling |
|
I'm open to bringing it back, but this PR will need some extra work:
|
|
Updated with your feedback |
|
Hi, I'm very happy to use j / k again, but if it conflicts with other features, |
|
Since the Emacs keymap does not break the search feature, how about splitting this option into two? For example: |
|
I'm super keen for this, and in the meantime the workaround to get "overrides": {
"@inquirer/core": "10.1.0",
"@inquirer/prompts": {
"@inquirer/core": "10.1.0"
}
}And also pin the following versions: "@inquirer/input": "4.2.1",
"@inquirer/prompts": "7.8.3" |
|
@LitoMore has a good interface proposal, let's refactor to adopt this syntax #1838 (comment) |
|
Went ahead fixing conflicts and changing the interface as per @LitoMore's suggestion. |
|
We can consider making the |
|
Yeah I considered that, but I think it's a future conflict waiting to happen. So I prefer to intentionally disable by default. |
#1822 removed the vim and emacs keybindings - this adds an option to
@inquirer/selectto support them again.