Kinsamanka/feature/#2135 tango controls support 2 7 2 #2401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Limraj wants to merge 4 commits into release/2.7.4 from kinsamanka/feature/#2135_TANGO_Controls_Support_2_7_2

Collaborator

Limraj commented Nov 21, 2022

No description provided.

Limraj and others added 2 commits

May 26, 2022 12:55


          #2135 Support for TANGO Controls protocol - java 11 in build.xml; sup…

db5d7b6

…port Tango


          #2135 Support for TANGO Controls protocol - correct libs

9ac30da

Limraj added this to the 2.7.4 milestone


          Merge branch 'release/2.7.4' into kinsamanka/feature/#2135_TANGO_Cont…

1455c2e

…rols_Support_2_7_2

github-actions bot commented Nov 21, 2022 •

edited

Loading

Java JUnit Test Results

1 536 tests ±0 1 536 ✔️ ±0 23s ⏱️ +3s
    82 suites ±0       0 💤 ±0
    82 files ±0       0 ❌ ±0

Results for commit fdd6182. ± Comparison against base commit 978ddf1.

♻️ This comment has been updated with latest results.

github-actions bot commented Nov 21, 2022 •

edited

Loading

Java Script Mocha Unit Test Results

268 tests ±0 268 ✔️ ±0 5s ⏱️ ±0s
  70 suites ±0     0 💤 ±0
    1 files ±0     0 ❌ ±0

Results for commit fdd6182. ± Comparison against base commit 978ddf1.

♻️ This comment has been updated with latest results.

github-advanced-security bot found potential problems

View reviewed changes

github-advanced-security bot left a comment

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.


          #2135 Support for TANGO Controls protocol - subscribes not in new thr…

fdd6182

…ead;

github-advanced-security bot found potential problems

View reviewed changes

src/com/serotonin/mango/rt/dataSource/tango/TangoDataSourceRT.java

+                                      devAttr.insert(iv);
+                                      break;
+                                  case TangoConst.Tango_DEV_SHORT:
+                                      devAttr.insert((short) iv);

Check failure

Code scanning / CodeQL

User-controlled data in numeric cast

This cast to a narrower type depends on a [user-provided value](1), potentially causing truncation. This cast to a narrower type depends on a [user-provided value](2), potentially causing truncation. This cast to a narrower type depends on a [user-provided value](3), potentially causing truncation. This cast to a narrower type depends on a [user-provided value](4), potentially causing truncation. This cast to a narrower type depends on a [user-provided value](5), potentially causing truncation.

src/com/serotonin/mango/rt/dataSource/tango/TangoDataSourceRT.java

+                                      devAttr.insert(dv);
+                                      break;
+                                  case TangoConst.Tango_DEV_FLOAT:
+                                      devAttr.insert((float) dv);

Check failure

Code scanning / CodeQL

User-controlled data in numeric cast

This cast to a narrower type depends on a [user-provided value](1), potentially causing truncation. This cast to a narrower type depends on a [user-provided value](2), potentially causing truncation. This cast to a narrower type depends on a [user-provided value](3), potentially causing truncation. This cast to a narrower type depends on a [user-provided value](4), potentially causing truncation. This cast to a narrower type depends on a [user-provided value](5), potentially causing truncation.

src/com/serotonin/mango/vo/dataSource/tango/TangoDataSourceVO.java

+               */
+              @JsonRemoteEntity
+              public class TangoDataSourceVO extends DataSourceVO<TangoDataSourceVO> {

Check failure

Code scanning / CodeQL

No clone method

No clone method, yet implements Cloneable.

src/com/serotonin/mango/rt/dataSource/tango/TangoDataSourceRT.java

+                      public int eventID;
+                  }
+                  private class EventCallBack extends CallBack {

Check warning

Code scanning / CodeQL

Serializable inner class of non-serializable class

Serializable inner class of non-serializable class [TangoDataSourceRT](1). Consider making the class static or implementing readObject() and writeObject().

src/com/serotonin/mango/rt/dataSource/tango/TangoDataSourceRT.java


		private class EventCallBack extends CallBack {

		public void push_event(EventData event) {

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [CallBack.push_event](1); it is advisable to add an Override annotation.

src/com/serotonin/mango/vo/dataSource/tango/TangoPointLocatorVO.java

+                      return new TangoPointLocatorRT(this);
+                  }
+                  public void validate(DwrResponseI18n response) {

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [PointLocatorVO.validate](1); it is advisable to add an Override annotation.

src/com/serotonin/mango/vo/dataSource/tango/TangoPointLocatorVO.java

+                      this.attribute = attribute;
+                  }
+                  public PointLocatorRT createRuntime() {

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [PointLocatorVO.createRuntime](1); it is advisable to add an Override annotation.

src/com/serotonin/mango/vo/dataSource/tango/TangoPointLocatorVO.java

+                      return new LocalizableMessage("common.default", attribute);
+                  }
+                  public boolean isSettable() {

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [PointLocatorVO.isSettable](1); it is advisable to add an Override annotation.

src/com/serotonin/mango/vo/dataSource/tango/TangoPointLocatorVO.java

+                      this.dataTypeId = dataTypeId;
+                  }
+                  public LocalizableMessage getConfigurationDescription() {

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [PointLocatorVO.getConfigurationDescription](1); it is advisable to add an Override annotation.

src/com/serotonin/mango/vo/dataSource/tango/TangoPointLocatorVO.java

+                  @JsonRemoteProperty
+                  private boolean settable;
+                  public int getDataTypeId() {

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [PointLocatorVO.getDataTypeId](1); it is advisable to add an Override annotation.

Limraj modified the milestones: 2.7.4, 2.7.5

Limraj removed this from the 2.7.5 milestone

Limraj added this to the 2.7.9 milestone

Limraj modified the milestones: 2.7.9, 2.9.0

Limraj removed this from the 2.9.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet