Skip to content

Conversation

@Limraj
Copy link
Collaborator

@Limraj Limraj commented Dec 23, 2025

No description provided.

Limraj and others added 30 commits July 31, 2025 15:38
- Updated use of @XssProtect annotation;
- Corrected definition tests in build.gradle for XssValidatorUtilsTestsSuite;
- Added support for List and Map for XssProtect annotations;
- Corrected protect in: FolderPointHierarchy, CompoundComponentDTO;
- Added support array for XssProtect annotation;
- Corrected protect for JsonEventSearch;
- Fixed select 'Add user' in MailingList;
- Added: UserIdentifier, AddressEntryJson, EmailRecipientJson, MailingListJson, UserEntryJson;
- Reduced data users in: ViewDwr, WatchListDwr, UsersDwr, ReportsDwr, MailingListsDwr, EventHandlersDwr, DataPointDetailsController;
- Corrected MailingListsDwr.getMailingList(int id);
- ReportsDwr.init;
…4_Updated_REST_API_with_incoming_data_for_XSS_protection
…I_with_incoming_data_for_XSS_protection

Feature/#3174 updated rest api with incoming data for xss protection
- Added block packages:
java.lang.Process.*
java.lang.invoke..*
java.io..*
java.nio..*

- Added access packages:
org.scada_lts..*
com.serotonin..*
cc.radiuino.scadabr..*
br.org.scadabr..*

java.util..*
java.lang..*
org.springframework.jdbc.core..*

- Added tests to ScriptExecutorTest;
- Added block packages:
java.lang.Process.*
java.lang.invoke..*
java.io..*
java.nio..*

- Added access packages:
java.util..*

- Added tests to ScriptExecutorTest;
- Added block packages:
java.lang.Process.*
java.lang.invoke..*
java.io..*
java.nio..*

- Added access packages:
java.util..*

- Added tests to ScriptExecutorTest;
- Refactor ScriptsAPI - using specially created exceptions for the REST API;
- Deprecated ScriptController and endpoint /script/execute/{xid} (use: /api/scripts/execute/{xid})
- Added or corrected name tests ScriptExecutorTestsSuite: JavaClassDeniedScriptExecutorTest,
JavaClassGrantedScriptExecutorTest,
JsScriptExecutorTest;
- Added migration: V2_8_1__SynopticPanelChangeDataTypeForColumnVectorImage
…t time:

- Corrected time for return to normal for DifferenceDetectorRT(NoChangeDetectorRT, NoUpdateDetectorRT);
- Corrected generate keystore added applicationUri, corrected other attributes;
- Set 20 for search depth limit;
- Revert scadalts.security.js.access.granted.class.regexes
…tween_Return_to_Normal_status_and_Reise_event_time

#3220 Fixed time shift between Return to Normal status and Reise even…
- Refactored OpcUaClientFactory and KeyStoreLoader;
- Created classes: CertificateDataImpl, ClientCertificate;
- Created interfaces: CertificateData, KeyStoreData;
- Created static factory method CertificateData.scadaLts
- Fixed DataPointRT.isUnreliable;
- Corrected message for exception from constructor ClientCertificate;
- svg.validator.messages.ignore - Added ignore message with path-effect;
- Removed import org.scada_lts.utils.PathSecureUtils in SvgProcessingUtils;
Limraj and others added 20 commits December 1, 2025 15:45
- Moved NettyTerminateUtils to impl package;
- Added PollingDataSourceUtils.terminateNetty;
- Moved NettyTerminateUtils to impl package;
- Added PollingDataSourceUtils.terminateNetty;
- Update docker-compose.yml, docker-compose-dev.yml;
- Created annotation java bean validation @scriptprotect: ScriptConstraintListValidator,ScriptValidator, ScriptValidatorUtils;
- Set @scriptprotect annotation: MetaPointLocatorJson, JsonScript,MetaPointLocatorVO, ScriptComponent, ScriptVO, PointLinkVO, ViewScriptComponentDTO;
- Set @XssProtect annotation: DataPointVO, UserComment, ImplDefinition, PointComponent, ScriptVO, ContextualizedScriptVO, ButtonComponent, ScriptButtonComponent, BinaryEventTextRenderer, MultistateEventValue, RangeEventValue, AlphanumericValue, PointEventDetectorVO, PointLinkVO;
- Added validation before execute script: ScriptExecutor, ContextualizedScriptRT;
- Added script validation before save: MetaPointLocatorVO, PointLinkVO, ScriptVO;
- Added classes: SandboxClassShutter,  ScriptContextUtils;
- Added exception: ScriptLocalizableException;
- Refactor ScriptsAPI.java;
- Removed deprecated classes: PointView.java,
AnalogImageSetRenderer.java
BaseGraphicRenderer.java
BasicImageRenderer.java
BasicRenderer.java
BinaryImageSetRenderer.java
DynamicImageRenderer.java
GraphicRenderer.java
ImageSetRenderer.java
MultistateImageSetRenderer.java
ScriptRenderer.java
ThumbnailRenderer.java;
- Fixed endpoint to test script, added: ScriptsAPI.executeScriptTest
- Corrected exception handler for Java Bean Validation error;
- Fixed endpoint /api/scripts/execute-test returned String message.
- Support deprecated endpoint /script;
- Added check isSecurityJsValidatorEnabled before validation;
- Added property scadalts.security.js.filter.enabled in env.properties;
…are_OPC_Server

#3213 How Connect to Kepware OPC Server:
- Corrected HeadersFromSystemSettingsWriter, if a given parameter exists, it is updated;
…_in_AuthenticationAPI

#3225 Wrong endpoint type in AuthenticationAPI
…ite_attribute_for_session_cookie

#3228 Configure SameSite attribute for session cookie
@Limraj Limraj requested a review from SoftQ as a code owner December 23, 2025 13:27
@coderabbitai
Copy link

coderabbitai bot commented Dec 23, 2025

Important

Review skipped

Too many files!

40 files out of 190 files are above the max files limit of 150.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Dec 23, 2025

Java Script Mocha Unit Test Results

268 tests  ±0   268 ✅ ±0   3s ⏱️ ±0s
 70 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 4943a13. ± Comparison against base commit 1cfaed4.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 23, 2025

Java JUnit Test Results

3 440 tests  +220   3 440 ✅ +220   52s ⏱️ -1s
  134 suites +  6       0 💤 ±  0 
  134 files   +  6       0 ❌ ±  0 

Results for commit 4943a13. ± Comparison against base commit 1cfaed4.

♻️ This comment has been updated with latest results.

@Limraj
Copy link
Collaborator Author

Limraj commented Dec 23, 2025

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Dec 23, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

- Corrected V2_8_1__SynopticPanelChangeDataTypeForColumnVectorImage;
@Limraj Limraj added this to the 2.8.1 milestone Dec 31, 2025
@Limraj
Copy link
Collaborator Author

Limraj commented Dec 31, 2025

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Dec 31, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants