Skip to content
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
7356936
#2779 Very slow editing of graphical chart:
Limraj Jan 2, 2026
72fac60
#2779 Very slow editing of graphical chart:
Limraj Jan 2, 2026
a801728
#2779 Very slow editing of graphical chart:
Limraj Jan 2, 2026
68f78a3
#2779 Very slow editing of graphical chart:
Limraj Jan 4, 2026
8a86338
#3237 Fixed Event Handlers:
Limraj Jan 4, 2026
559906b
#3237 Fixed Event Handlers:
Limraj Jan 4, 2026
92ccee4
Merge pull request #3238 from SCADA-LTS/fix/#3237_Fixed_Event_Handlers
Limraj Jan 5, 2026
491ff19
#2779 Very slow editing of graphical chart:
Limraj Jan 5, 2026
6de7191
#2779 Very slow editing of graphical chart:
Limraj Jan 6, 2026
2a7da97
#2779 Very slow editing of graphical chart:
Limraj Jan 6, 2026
e8ddaaa
#2779 very slow editing of graphical chart:
Limraj Jan 7, 2026
aec7d08
#2779 Very slow editing of graphical chart:
Limraj Jan 8, 2026
cc26245
#2779 Very slow editing of graphical chart:
Limraj Jan 8, 2026
64708f2
#2779 Very slow editing of graphical chart:
Limraj Jan 8, 2026
00a10e1
#2779 very slow editing of graphical chart:
Limraj Jan 9, 2026
4cbbfff
#2779 Very slow editing of graphical chart:
Limraj Jan 9, 2026
e774845
#2779 Very slow editing of graphical chart:
Limraj Jan 11, 2026
4dd033c
#2779 very slow editing of graphical chart:
Limraj Jan 11, 2026
99569bb
#2779 very slow editing of graphical chart:
Limraj Jan 12, 2026
a5a94b4
#2779 very slow editing of graphical chart:
Limraj Jan 12, 2026
262e080
#2779 very slow editing of graphical chart:
Limraj Jan 12, 2026
a1387a0
#2779 Very slow editing of graphical chart:
Limraj Jan 12, 2026
908c96f
#2779 very slow editing of graphical chart:
Limraj Jan 15, 2026
20d906d
#2779 very slow editing of graphical chart:
Limraj Jan 15, 2026
3e649aa
#2779 very slow editing of graphical chart:
Limraj Jan 15, 2026
597655b
#2779 very slow editing of graphical chart:
Limraj Jan 15, 2026
8a41eab
#2779 very slow editing of graphical chart:
Limraj Jan 15, 2026
7c86d85
#2779 very slow editing of graphical chart:
Limraj Jan 16, 2026
ebbb384
#2779 very slow editing of graphical chart:
Limraj Jan 21, 2026
7c65ffb
#2779 very slow editing of graphical chart:
Limraj Jan 21, 2026
71bf947
#2779 very slow editing of graphical chart:
Limraj Jan 21, 2026
a64e5c0
#2779 very slow editing of graphical chart:
Limraj Jan 21, 2026
283fc70
#2779 very slow editing of graphical chart:
Limraj Jan 21, 2026
ecdaa44
#2779 very slow editing of graphical chart:
Limraj Jan 21, 2026
2b4183e
#2779 very slow editing of graphical chart:
Limraj Jan 21, 2026
d1b1dab
#2779 very slow editing of graphical chart:
Limraj Jan 21, 2026
aa44da1
#2779 very slow editing of graphical chart:
Limraj Jan 21, 2026
d8aaf11
#2779 very slow editing of graphical chart:
Limraj Jan 22, 2026
08cf570
#2779 very slow editing of graphical chart:
Limraj Jan 22, 2026
b30cbe2
#2779 Very slow editing of graphical chart:
Limraj Jan 22, 2026
11f911c
#2779 Very slow editing of graphical chart:
Limraj Jan 22, 2026
1986009
#2779 Very slow editing of graphical chart:
Limraj Jan 23, 2026
1bf4310
#2779 Very slow editing of graphical chart:
Limraj Jan 23, 2026
089559a
#2779 Very slow editing of graphical chart:
Limraj Jan 27, 2026
863bef2
#3242 Fixed BACnet Read:
Limraj Jan 27, 2026
b45be1f
#2779 very slow editing of graphical chart:
Limraj Jan 27, 2026
03d2728
Merge branch 'fix/#2779_Very_slow_editing_of_graphical_chart' into fi…
Limraj Jan 27, 2026
1d36799
#2779 very slow editing of graphical chart:
Limraj Jan 27, 2026
3787022
Merge remote-tracking branch 'origin/fix/#2779_Very_slow_editing_of_g…
Limraj Jan 27, 2026
58577be
#2779 very slow editing of graphical chart:
Limraj Jan 27, 2026
01bc63e
Merge remote-tracking branch 'origin/fix/#2779_Very_slow_editing_of_g…
Limraj Jan 27, 2026
8a7d1f6
Merge pull request #3243 from SCADA-LTS/fix/#3242_Fixed_BACnet_Read
Limraj Jan 28, 2026
64e825c
#2779 very slow editing of graphical chart:
Limraj Jan 28, 2026
1dcec00
#2779 very slow editing of graphical chart:
Limraj Jan 28, 2026
74872d5
#2779 very slow editing of graphical chart:
Limraj Jan 28, 2026
003dd87
#2779 very slow editing of graphical chart:
Limraj Jan 28, 2026
a5700ce
#2779 very slow editing of graphical chart:
Limraj Jan 29, 2026
7f60209
#2779 very slow editing of graphical chart:
Limraj Jan 29, 2026
54c3856
#2779 very slow editing of graphical chart:
Limraj Jan 29, 2026
edf80cb
#2779 very slow editing of graphical chart:
Limraj Jan 29, 2026
67d6bb2
#2779 very slow editing of graphical chart:
Limraj Jan 30, 2026
b106e67
#2779 very slow editing of graphical chart:
Limraj Jan 30, 2026
f905db8
#2779 very slow editing of graphical chart:
Limraj Jan 30, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion WebContent/WEB-INF/dwr.xml
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@
<param name="include" value="id,xid,name,extendedName,dataSourceId,enabled,dataTypeMessage,pointLocator,engineeringUnits"/>
</convert>
<convert converter="xssDataPointBeanConverter" match="com.serotonin.mango.web.dwr.beans.DataPointBean">
<param name="include" value="id,xid,name,settable,dataType,dataTypeMessage,chartColour"/>
<param name="include" value="id,xid,name,settable,dataType,dataTypeMessage,chartColour,enabled"/>
</convert>
<convert converter="bean" match="com.serotonin.mango.vo.User">
<param name="include" value="id,username,email,phone,admin,disabled,receiveAlarmEmails,receiveOwnAuditEvents,dataSourcePermissions,dataPointPermissions,userProfile,homeUrl,hideMenu,theme,firstName,lastName,enableFullScreen,hideShortcutDisableFullScreen"/>
Expand Down
33 changes: 14 additions & 19 deletions WebContent/WEB-INF/jsp/dataPointDetails.jsp
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,19 @@
</c:if>
<c:if test="${!empty flipbookLimit}">getFlipbookChart();</c:if>
getStatsChart();

jQuery("#datPointDetailsPointSelect").chosen({
allow_single_deselect: true,
placeholder_text_single: " ",
search_contains: true,
width: "400px"
});

let pointsArray = new Array();

<c:forEach items="${userPoints}" var="dp">
pointsArray[pointsArray.length] = {
id : "<c:out value="${dp.id}"/>",
name : "<c:out value="${dp.extendedName}"/>",
xid : "<c:out value="${dp.xid}"/>",
dataType : "<sst:i18n message="${dp.dataTypeMessage}"/>"
};
</c:forEach>

let datPointDetailsPointSelect = initPointsSelect("datPointDetailsPointSelect", "<spring:message code='chosen.selector.selectPoint'/>", "400px", [], pointsArray.filter((point) => point.id == <c:out value="${point.id}" />), [], true);
}

//
Expand Down Expand Up @@ -152,24 +158,13 @@
function swapFlipbookImage(uri) {
$("flipbookImage").src = uri;
}

jQuery(document).ready(function(){
(function($) {
loadjscssfile("resources/jQuery/plugins/chosen/chosen.min.css","css");
loadjscssfile("resources/jQuery/plugins/chosen/chosen.jquery.min.js","js");
})(jQuery);
});
</script>

<table width="100%">
<tr>
<td valign="top" align="right">
<spring:message code="pointDetails.goto"/>:&nbsp;
<sst:select id="datPointDetailsPointSelect" value="${point.id}" onchange="window.location='data_point_details.shtm?dpid='+ this.value;">
<c:forEach items="${userPoints}" var="point">
<sst:option value="${point.id}"><c:out value="${point.extendedName}"/></sst:option>
</c:forEach>
</sst:select>
<select id="datPointDetailsPointSelect" value="${point.id}" onchange="window.location='data_point_details.shtm?dpid='+ this.value;" />

<c:if test="${!empty prevId}">
<tag:img png="bullet_go_left" title="pagination.previous"
Expand Down
18 changes: 3 additions & 15 deletions WebContent/WEB-INF/jsp/dataPointEdit.jsp
Original file line number Diff line number Diff line change
Expand Up @@ -83,14 +83,9 @@
<tr>
<td>
<script>
function init() {
jQuery("#selected_base_on_existing_point_chooser").chosen({
allow_single_deselect: true,
placeholder_text_single: "<spring:message code='chosen.selector.selectPoint'/>",
search_contains: true,
width: "400px"
});
}
function init() {
let selectedBaseOnExistingPointChooser = initPointsSelect("selected_base_on_existing_point_chooser", "<spring:message code='chosen.selector.selectPoint'/>");
}

function checkGetAlertError() {
return jQuery("#checkGetAlertError").prop('checked');
Expand Down Expand Up @@ -892,13 +887,6 @@
});
}

jQuery(document).ready(function(){
(function($) {
loadjscssfile("resources/jQuery/plugins/chosen/chosen.min.css","css");
loadjscssfile("resources/jQuery/plugins/chosen/chosen.jquery.min.js","js");
})(jQuery);
});

jQuery(document).ready(function() {
function updateSuffixForEngineeringUnits() {
let value = jQuery("select[name='engineeringUnits']").val();
Expand Down
23 changes: 12 additions & 11 deletions WebContent/WEB-INF/jsp/dataSourceEdit.jsp
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@
hide(dsStatus);

if (typeof initImpl == 'function') initImpl();

DataSourceEditDwr.editInit(initCB);
let dataSourceId = '${dataSource.id}' ? '${dataSource.id}': '-1';
DataSourceEditDwr.editInit(dataSourceId, initCB);
showMessage("dataSourceMessage");
showMessage("pointMessage");
}
Expand Down Expand Up @@ -209,23 +209,24 @@
var childs = document.getElementById("editImg" + currentPoint.id).parentNode.parentNode.childNodes;
if (currentPoint.id!=-1) markRow(childs, false);
}
DataSourceEditDwr.getPoint(pointId, editPointCB);
DataSourceEditDwr.getDataPoint(pointId, editPointCB);
hideContextualMessages("pointProperties");
}

function editPointCB(point) {
currentPoint = point;
display("pointDeleteImg", point.id != <c:out value="<%=Common.NEW_ID%>"/>);
var locator = currentPoint.pointLocator;
function editPointCB(response) {
currentPoint = response.data.point;
display("pointDeleteImg", currentPoint.id != <c:out value="<%=Common.NEW_ID%>"/>);
let locator = currentPoint.pointLocator;
let contextPoints = response.data.contextPoints;

$set("name", unescapeHtml(currentPoint.name));
$set("xid", unescapeHtml(currentPoint.xid));
var cancel;
if (typeof editPointCBImpl == 'function') cancel = editPointCBImpl(locator);
if (typeof editPointCBImpl == 'function') cancel = editPointCBImpl(locator, contextPoints);
if (!cancel) {
startImageFader("editImg"+ point.id);
if(point.id!=-1) {
var childs = document.getElementById("editImg" + point.id).parentNode.parentNode.childNodes;
startImageFader("editImg"+ currentPoint.id);
if(currentPoint.id!=-1) {
var childs = document.getElementById("editImg" + currentPoint.id).parentNode.parentNode.childNodes;
markRow(childs, true);
}
show("pointDetails");
Expand Down
4 changes: 2 additions & 2 deletions WebContent/WEB-INF/jsp/dataSourceEdit/editJmx.jsp
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,8 @@
}

function addPointImpl() {
DataSourceEditDwr.getPoint(-1, function(point) {
editPointCB(point);
DataSourceEditDwr.getDataPoint(-1, function(response) {
editPointCB(response.data.point);
$set("objectName", addPointData.objectName);
$set("attributeName", addPointData.attrName);
$set("compositeItemName", addPointData.compositeName);
Expand Down
57 changes: 19 additions & 38 deletions WebContent/WEB-INF/jsp/dataSourceEdit/editMeta.jsp
Original file line number Diff line number Diff line change
Expand Up @@ -21,28 +21,11 @@
<%@page import="com.serotonin.mango.Common"%>

<script type="text/javascript">
var pointsArray = new Array();
var scriptPointsContext;

var pointsContext;

function initImpl() {
<c:forEach items="${userPoints}" var="dp">
pointsArray[pointsArray.length] = {
id : ${dp.id},
name : "<c:out value="${dp.extendedName}"/>",
xid : "<c:out value="${dp.xid}"/>",
type : "<sst:i18n message="${dp.dataTypeMessage}"/>"
};
</c:forEach>

createContextualMessageNode("contextContainer", "context");

jQuery("#allPointsList").chosen({
allow_single_deselect: true,
placeholder_text_single: " ",
search_contains: true,
width: "400px"
});

}

function appendPointListColumnFunctions(pointListColumnHeaders, pointListColumnFunctions) {
Expand All @@ -67,15 +50,20 @@
DataSourceEditDwr.saveMetaDataSource($get("dataSourceName"), $get("dataSourceXid"), saveDataSourceCB);
}

function editPointCBImpl(locator) {
if (this.scriptPointsContext) {
for (var i = 0; i < locator.context.length; i++) {
this.scriptPointsContext.addToContextArray(locator.context[i].key, locator.context[i].value);
}
this.scriptPointsContext.writeContextArray();
} else {
this.scriptPointsContext = new ScriptPointsContext(locator.context, pointsArray);
}
function editPointCBImpl(locator, contextPoints) {

let ref = {}
ref.excludePointsArray = locator.context;
ref.limit = 500;
ref.selectHtmlId = "allPointsList";
ref.placeholderTextSingle = "<spring:message code='chosen.selector.selectPoint'/>";
ref.pointsArray = contextPoints;
ref.dataTypes = [];
ref.altKey = "id";
ref.altValue = "name";
ref.widthPx = "400px";

this.pointsContext = new ScriptPointsContext(ref);
$set("script", locator.script);
$set("dataTypeId", locator.dataTypeId);
$set("settable", locator.settable);
Expand All @@ -89,7 +77,7 @@
}

function savePointImpl(locator) {
locator.context = this.scriptPointsContext.convertToSave();
locator.context = this.pointsContext.convertToSave();
locator.script = $get("script");
locator.dataTypeId = $get("dataTypeId");
locator.settable = $get("settable");
Expand All @@ -103,7 +91,7 @@

function validateScript() {
hideContextualMessages("pointProperties");
DataSourceEditDwr.validateScript($get("script"), this.scriptPointsContext.convertToSave(), $get("dataTypeId"), validateScriptCB);
DataSourceEditDwr.validateScript($get("script"), this.pointsContext.convertToSave(), $get("dataTypeId"), validateScriptCB);
}

function validateScriptCB(response) {
Expand All @@ -113,13 +101,6 @@
function updateEventChanged() {
display("updateCronPatternRow", $get("updateEvent") == <%= MetaPointLocatorVO.UPDATE_EVENT_CRON %>);
}

jQuery(document).ready(function(){
(function($) {
loadjscssfile("resources/jQuery/plugins/chosen/chosen.min.css","css");
loadjscssfile("resources/jQuery/plugins/chosen/chosen.jquery.min.js","js");
})(jQuery);
});
</script>

<c:set var="dsDesc"><spring:message code="dsEdit.meta.desc"/></c:set>
Expand All @@ -146,7 +127,7 @@
<td class="formLabelRequired"><spring:message code="dsEdit.meta.scriptContext"/></td>
<td class="formField">
<select id="allPointsList"></select>
<tag:img png="add" onclick="scriptPointsContext.addPointToContext();" title="common.add"/>
<tag:img png="add" onclick="pointsContext.addPointToContext(this.value);" title="common.add"/>

<table cellspacing="1" id="contextContainer">
<tbody id="contextTableEmpty" style="display:none;">
Expand Down
4 changes: 2 additions & 2 deletions WebContent/WEB-INF/jsp/dataSourceEdit/editModbus.jsp
Original file line number Diff line number Diff line change
Expand Up @@ -217,8 +217,8 @@
}

function addPointImpl() {
DataSourceEditDwr.getPoint(-1, function(point) {
editPointCB(point);
DataSourceEditDwr.getDataPoint(-1, function(response) {
editPointCB(response.data.point);
$set("slaveId", $get("test_slaveId"));
$set("range", $get("test_range"));
$set("modbusDataType", $get("test_modbusDataType"));
Expand Down
8 changes: 6 additions & 2 deletions WebContent/WEB-INF/jsp/dataSourceEdit/editOpc.jsp
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,9 @@
}

function addTags() {
DataSourceEditDwr.getPoint(-1, addTagsImpl);
DataSourceEditDwr.getDataPoint(-1, function(response) {
addTagsImpl(response.data.point);
});
}

function addTagsImpl(point) {
Expand Down Expand Up @@ -142,7 +144,9 @@
}

function btnAddTag() {
DataSourceEditDwr.getPoint(-1, addTagsImplOPC);
DataSourceEditDwr.getDataPoint(-1, function(response) {
addTagsImplOPC(response.data.point);
});
}

function addTagsImplOPC(point) {
Expand Down
4 changes: 3 additions & 1 deletion WebContent/WEB-INF/jsp/dataSourceEdit/editOpcUa.jsp
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,9 @@
}

function btnAddNode() {
DataSourceEditDwr.getPoint(-1, addNodesImplOpcUa);
DataSourceEditDwr.getDataPoint(-1, function(response) {
addNodesImplOpcUa(response.data.point);
});
}

function addNodesImplOpcUa(point) {
Expand Down
Loading
Loading