Skip to content

Conversation

@codebyemily
Copy link

for issue #9

Copy link

@charred-70 charred-70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super tuff gang

Copy link
Contributor

@evanugarte evanugarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we get a copy paste of the full json, as is in the below issue? i wanna see what it looks like

#9 (comment)

server.py Outdated
MetricsHandler.last_smee_request_timestamp.set(time.time())
payload_body = await request.body()
payload = json.loads(payload_body)
print("Payload:", payload) # simpler
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove this

"status": f"X-GitHub-Event header was not set to push, got value {event_header}"
"status": f"commit recorded"
}
elif event_header == "workflow_run":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also maybe this should get moved to its own function, where we pass in payload and repo_name and branch?

Suggested change
elif event_header == "workflow_run":
if event_header == "workflow_run":
handle_workflow_run(...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants