-
Notifications
You must be signed in to change notification settings - Fork 5
check successful workflow run #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
check successful workflow run #14
Conversation
…ub_actions_before_applying_change creating cicd actions step
charred-70
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super tuff gang
evanugarte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we get a copy paste of the full json, as is in the below issue? i wanna see what it looks like
server.py
Outdated
| MetricsHandler.last_smee_request_timestamp.set(time.time()) | ||
| payload_body = await request.body() | ||
| payload = json.loads(payload_body) | ||
| print("Payload:", payload) # simpler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove this
| "status": f"X-GitHub-Event header was not set to push, got value {event_header}" | ||
| "status": f"commit recorded" | ||
| } | ||
| elif event_header == "workflow_run": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also maybe this should get moved to its own function, where we pass in payload and repo_name and branch?
| elif event_header == "workflow_run": | |
| if event_header == "workflow_run": | |
| handle_workflow_run(...) |
for issue #9