Add Prometheus metric for Docker image disk usage #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a python function that runs the shell command and parses the output, returning the disk usage as an integer
Added a Gauge metric for tracking total disk usage of Docker images. add Prometheus metric for Docker image disk usage
fixed the docker command to get the total bytes used in a single number for images
Tomajari
changed the title
helps prevent duplicate Prometheus metric registration with get_or_create_gauge
evanugarte
reviewed
Jan 10, 2026
Co-authored-by: Evan Ugarte <[email protected]>
changed to return int(output) since the float function is only needed if the output could be a float string Co-authored-by: Evan Ugarte <[email protected]>
This function will be moved to metricsHandler
Moved prometheus metric registration from server.py to metricsHandler
evanugarte
reviewed
Jan 11, 2026
Comment on lines
17
to
18
|
|
||
|
|
Contributor
There was a problem hiding this comment.
undo this change, lets add the 2 lines back
server.py
Outdated
Comment on lines
137
to
140
| cmd = [ | ||
| "sh", "-c", | ||
| 'docker images --format "{{.Size}}" | awk \'/GB/ {gsub("GB", ""); sum+=($1*1024*1024*1024)} /MB/ {gsub("MB", ""); sum+=($1*1024*1024)} /kB/ {gsub("kB", ""); sum+=($1*1024)} END {print int(sum)}\'' | ||
| ] |
Contributor
There was a problem hiding this comment.
in your computer, whats the output of
docker system df --format {{json .}}
is there an "Images" section, if so, can we pull the size from there instead?
Author
There was a problem hiding this comment.
Yes theres an image section and this is what it outputs in the terminal
Refactor get_docker_images_disk_usage_bytes to use 'docker system df' for disk usage calculation.
evanugarte
approved these changes
Jan 12, 2026
| logger.exception("push_update_success_as_discord_embed had a bad time") | ||
|
|
||
| def get_docker_images_disk_usage_bytes(): | ||
| try: |
Contributor
There was a problem hiding this comment.
we have a try, do we have an except for this? similar to 132
added exception error block for get_docker_images_disk_usage_bytes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a Prometheus metric that reports the total disk usage of all Docker images on the host. This helps allow to track Docker image storageusage over time in the monitoring dashbaords.
To test this:
Activate virtual environment source .venv/bin/activate
instal dependencies: pip install -r requirements.txt
run the FastAPI server: uvicorn server:app --port 3000 --reload
check metrics endpoint using http://127.0.0.1:3000/metrics
Look for a line that says "docker_image_disk_usage_bytes "
Example: