Skip to content

prevent race conditions on threads #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ra2y wants to merge 1 commit into
base: main
Choose a base branch
from
Open

prevent race conditions on threads #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import requests
import time
from metrics import MetricsHandler
from queue import Queue


from prometheus_client import generate_latest
Expand Down Expand Up @@ -204,11 +205,31 @@ async def github_webhook(request: Request):

logger.info(f"Push to {branch} detected for {repo_name}")
# update the repo
if deployment_line.qsize() == 1:
print("kicking a guy outta line rn brb")
deployment_line.get()
thread = threading.Thread(target=update_repo, args=(config[key],))
thread.start()
# thread.start()
deployment_line.put(thread)

return {"status": "webhook received"}

# perhaps we create a separate handler for threads
# a queue for threads
# every webhook call adds it to the queue for threads
# we built dis city
# we built dis city on queues and threads
deployment_line = Queue()

def deployment_house():
print("hai welcome to the deployment house")
while True:
my_thread = deployment_line.get()
my_thread.start()
my_thread.join()

deployment_thread = threading.Thread(target=deployment_house, daemon=True)
deployment_thread.start()

@app.get("/metrics")
def get_metrics():
Expand Down