Fix balancing empty parts with metis #499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- test/mbalanceEmpty.cc: add test to try to balance with empty input parts, which may occur during cavity operator localization. - test/CMakeLists.txt: add mbalanceEmpty. - test/testing.cmake: add mbalanceEmpty. - add msplit dependencies on convert given ENABLE_SIMMETRIX. Signed-off-by: Aiden Woodruff <[email protected]>
- change asserts to debug since they are on helpers and any bad input should be programmer error. - metis/apfMETISbalancer.cc (gatherGraph): change precondition from |owned_xadj| > 1 to owned_xadj is non-empty. an empty xadj should just have the number 0. - (scatterPart): remove n_owned > 0. send/receive 0 should just be a no-op. Signed-off-by: Aiden Woodruff <[email protected]>
Contributor
|
/runtests |
cwsmith
reviewed
Jun 23, 2025
|
Build Log |
Co-authored-by: Cameron Smith <[email protected]>
- test/mbalanceEmpty.cc: add info to USAGE text about new requirement. - check for inParts >= PCU.Peers and throw. - print exceptions with nested printing function. - alter scope so that PCU.Self() can be used from exception printing code. - add retval to only write pcu::Finalize once. Signed-off-by: Aiden Woodruff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix balancing empty parts with metis