Skip to content

Conversation

@regpacy
Copy link

@regpacy regpacy commented Sep 22, 2025

Closes #167

Copy link

@cwsmith cwsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution and quick response! Are you an RPI student?

Two minor edits are requested below.

@regpacy
Copy link
Author

regpacy commented Sep 23, 2025

Hello, I resolved issues that you pointed out! and no I am not student at RPI.

@regpacy regpacy requested a review from cwsmith September 23, 2025 13:22
@cwsmith
Copy link

cwsmith commented Sep 23, 2025

Thank you.

If you have more time to put into this, would you please take a look at the CI failures?
https://github.com/SCOREC/omega_h/actions/runs/17946795469/job/51040682205?pr=168#step:10:323
It looks like they are in vtkdiff.cpp and Omega_h_vtk.hpp.

@cwsmith
Copy link

cwsmith commented Sep 23, 2025

/runtests

@github-actions
Copy link

Test Result: failure (details)

@cwsmith
Copy link

cwsmith commented Sep 23, 2025

Thanks for the fixes.
A few more spots are in an interface to a third party package:
https://github.com/SCOREC/omega_h/actions/runs/17950828852/job/51049377874#step:3:956

git grep filesystem | grep -v std:: may help locate remaining uses.

Sichao25 pushed a commit to Sichao25/omega_h that referenced this pull request Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove Omega_h_filesystem and use std::filesystem

2 participants