Skip to content

Debug simplified field compilation and runtime issues #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacobmerson merged 9 commits into from
Dec 9, 2025
Merged

Debug simplified field compilation and runtime issues #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
15b3abc
debug simplified field gpu build
Sichao25 Nov 25, 2025
857b867
remove redundant copy
Sichao25 Nov 25, 2025
f0dcd25
add host members to point cloud
Sichao25 Nov 26, 2025
9d4a6aa
debug potential memory access violation
Sichao25 Nov 26, 2025
3e4da7c
cleanup debugging code
Sichao25 Nov 26, 2025
68c63cb
debug spline interpolator
Sichao25 Dec 1, 2025
12645c8
add view copy and iota utility functions
Sichao25 Dec 7, 2025
7a21f8e
Merge branch 'develop' into yus/debug_gpu_build
Sichao25 Dec 8, 2025
33258d6
Merge branch 'develop' into yus/debug_gpu_build
Sichao25 Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
153 changes: 125 additions & 28 deletions src/pcms/adapter/omega_h/omega_h_field2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,16 @@ class MeshFieldBackendImpl : public MeshFieldBackend
{
size_t stride = num_nodes * num_components;
auto topo = static_cast<MeshField::Mesh_Topology>(dim);
Kokkos::View<Real*, DefaultExecutionSpace::memory_space> data_d(
"data_d", data.size());
Kokkos::deep_copy(data_d, Kokkos::View<const Real*, HostMemorySpace>(
data.data_handle(), data.size()));
Omega_h::parallel_for(
mesh_.nents(dim), OMEGA_H_LAMBDA(size_t ent) {
for (size_t n = 0; n < num_nodes; ++n) {
for (size_t c = 0; c < num_components; ++c) {
shape_field_(ent, n, c, topo) =
data[ent * stride + n * num_components + c];
data_d[ent * stride + n * num_components + c];
}
}
});
Expand All @@ -45,15 +49,20 @@ class MeshFieldBackendImpl : public MeshFieldBackend
{
size_t stride = num_nodes * num_components;
auto topo = static_cast<MeshField::Mesh_Topology>(dim);
Kokkos::View<Real*, DefaultExecutionSpace::memory_space> data_d(
"data_d", data.size());
Omega_h::parallel_for(
mesh_.nents(dim), OMEGA_H_LAMBDA(size_t ent) {
for (size_t n = 0; n < num_nodes; ++n) {
for (size_t c = 0; c < num_components; ++c) {
data[ent * stride + n * num_components + c] =
data_d[ent * stride + n * num_components + c] =
shape_field_(ent, n, c, topo);
}
}
});
Kokkos::deep_copy(
Kokkos::View<Real*, HostMemorySpace>(data.data_handle(), data.size()),
data_d);
}

private:
Expand All @@ -64,31 +73,110 @@ class MeshFieldBackendImpl : public MeshFieldBackend
ShapeField shape_field_;
};

struct ComputeOffsetsFunctor
{
Kokkos::View<LO*, HostMemorySpace> offsets_;
Kokkos::View<LO*, HostMemorySpace> elem_counts_;

ComputeOffsetsFunctor(Kokkos::View<LO*, HostMemorySpace> offsets,
Kokkos::View<LO*, HostMemorySpace> elem_counts)
: offsets_(offsets), elem_counts_(elem_counts)
{
}

KOKKOS_INLINE_FUNCTION
void operator()(LO i, LO& partial, bool is_final) const
{
if (is_final) {
offsets_(i) = partial;
}
partial += elem_counts_(i);
}
};

struct CountPointsPerElementFunctor
{
Kokkos::View<LO*> elem_counts_;
Kokkos::View<GridPointSearch::Result*> search_results_;

CountPointsPerElementFunctor(
Kokkos::View<LO*> elem_counts,
Kokkos::View<GridPointSearch::Result*> search_results)
: elem_counts_(elem_counts), search_results_(search_results)
{
}

KOKKOS_INLINE_FUNCTION
void operator()(LO i) const
{
auto [dim, elem_idx, coord] = search_results_(i);
Kokkos::atomic_add(&elem_counts_(elem_idx), 1);
}
};

struct FillCoordinatesAndIndicesFunctor
{
Omega_h::Mesh& mesh_;
Kokkos::View<LO*> elem_counts_;
Kokkos::View<LO*> offsets_;
Kokkos::View<Real**> coordinates_;
Kokkos::View<LO*> indices_;
Kokkos::View<GridPointSearch::Result*> search_results_;

FillCoordinatesAndIndicesFunctor(
Omega_h::Mesh& mesh, Kokkos::View<LO*> elem_counts,
Kokkos::View<LO*> offsets, Kokkos::View<Real**> coordinates,
Kokkos::View<LO*> indices,
Kokkos::View<GridPointSearch::Result*> search_results)
: mesh_(mesh),
elem_counts_(elem_counts),
offsets_(offsets),
coordinates_(coordinates),
indices_(indices),
search_results_(search_results)
{
}

KOKKOS_INLINE_FUNCTION
void operator()(LO i) const
{
auto [dim, elem_idx, coord] = search_results_(i);
// currently don't handle case where point is on a boundary
PCMS_ALWAYS_ASSERT(static_cast<int>(dim) == mesh_.dim());
// element should be inside the domain (positive)
PCMS_ALWAYS_ASSERT(elem_idx >= 0 && elem_idx < mesh_.nelems());
LO count = Kokkos::atomic_sub_fetch(&elem_counts_(elem_idx), 1);
LO index = offsets_(elem_idx) + count - 1;
for (int j = 0; j < (mesh_.dim() + 1); ++j) {
coordinates_(index, j) = coord[j];
}
indices_(index) = i;
}
};

struct OmegaHField2LocalizationHint
{
OmegaHField2LocalizationHint(
Omega_h::Mesh& mesh, Kokkos::View<GridPointSearch::Result*> search_results)
Omega_h::Mesh& mesh,
Kokkos::View<GridPointSearch::Result*, HostMemorySpace> search_results)
: offsets_("", mesh.nelems() + 1),
coordinates_("", search_results.size(), mesh.dim() + 1),
indices_("", search_results.size())
{
Kokkos::View<LO*> elem_counts("", mesh.nelems());
Kokkos::View<LO*, HostMemorySpace> elem_counts("", mesh.nelems());

for (size_t i = 0; i < search_results.size(); ++i) {
auto [dim, elem_idx, coord] = search_results(i);
elem_counts[elem_idx] += 1;
}

LO total;

ComputeOffsetsFunctor functor(offsets_, elem_counts);
Kokkos::parallel_scan(
mesh.nelems(),
KOKKOS_LAMBDA(LO i, LO & partial, bool is_final) {
if (is_final) {
offsets_(i) = partial;
}
partial += elem_counts(i);
},
total);
"ComputeOffsets",
Kokkos::RangePolicy<HostMemorySpace::execution_space>(0, mesh.nelems()),
functor, total);
offsets_(mesh.nelems()) = total;

for (size_t i = 0; i < search_results.size(); ++i) {
Expand All @@ -108,11 +196,11 @@ struct OmegaHField2LocalizationHint
}

// offsets is the number of points in each element
Kokkos::View<LO*> offsets_;
Kokkos::View<LO*, HostMemorySpace> offsets_;
// coordinates are the parametric coordinates of each point
Kokkos::View<Real**> coordinates_;
Kokkos::View<Real**, HostMemorySpace> coordinates_;
// indices are the index of the original point
Kokkos::View<LO*> indices_;
Kokkos::View<LO*, HostMemorySpace> indices_;
};

/*
Expand Down Expand Up @@ -207,13 +295,14 @@ LocalizationHint OmegaHField2::GetLocalizationHint(

auto coordinates = coordinate_view.GetCoordinates();
Kokkos::View<Real* [2]> coords("coords", coordinates.size() / 2);
Kokkos::parallel_for(
coordinates.size() / 2, KOKKOS_LAMBDA(LO i) {
coords(i, 0) = coordinates(i, 0);
coords(i, 1) = coordinates(i, 1);
});
auto coordinates_host = Kokkos::View<const Real**, HostMemorySpace>(
coordinates.data_handle(), coordinates.extent(0), coordinates.extent(1));
deep_copy_mismatch_layouts(coords, coordinates_host);
auto results = search_(coords);
auto hint = std::make_shared<OmegaHField2LocalizationHint>(mesh_, results);
Kokkos::View<GridPointSearch::Result*, HostMemorySpace> results_h(
"results_h", results.size());
Kokkos::deep_copy(results_h, results);
auto hint = std::make_shared<OmegaHField2LocalizationHint>(mesh_, results_h);

return LocalizationHint{hint};
}
Expand All @@ -233,13 +322,21 @@ void OmegaHField2::Evaluate(LocalizationHint location,
OmegaHField2LocalizationHint hint =
*reinterpret_cast<OmegaHField2LocalizationHint*>(location.data.get());

auto eval_results = mesh_field_->evaluate(hint.coordinates_, hint.offsets_);

Kokkos::View<Real**> coordinates_d(
"coordinates_d", hint.coordinates_.extent(0), hint.coordinates_.extent(1));
deep_copy_mismatch_layouts(coordinates_d, hint.coordinates_);
Kokkos::View<LO*> offsets_d("offsets_d", hint.offsets_.extent(0));
Kokkos::deep_copy(offsets_d, hint.offsets_);
auto eval_results = mesh_field_->evaluate(coordinates_d, offsets_d);
Kokkos::View<Real**, HostMemorySpace> eval_results_h(
"eval_results_h", eval_results.extent(0), eval_results.extent(1));
deep_copy_mismatch_layouts(eval_results_h, eval_results);
Rank1View<Real, HostMemorySpace> values = results.GetValues();

Kokkos::parallel_for(
eval_results.size(),
KOKKOS_LAMBDA(LO i) { values[hint.indices_(i)] = eval_results(i, 0); });
"CopyEvalResultsToValues",
Kokkos::RangePolicy<HostMemorySpace::execution_space>(
0, eval_results_h.extent(0)),
KOKKOS_LAMBDA(LO i) { values[hint.indices_(i)] = eval_results_h(i, 0); });
}

void OmegaHField2::EvaluateGradient(
Expand Down Expand Up @@ -288,7 +385,7 @@ void OmegaHField2::Deserialize(
if (owned[i])
sorted_buffer[i] = buffer[permutation[i]];
}
const auto sorted_buffer_d = Omega_h::Read<Real>(sorted_buffer);
SetDOFHolderData(pcms::make_const_array_view(sorted_buffer_d));

SetDOFHolderData(pcms::make_const_array_view(sorted_buffer));
}
} // namespace pcms
2 changes: 1 addition & 1 deletion src/pcms/adapter/omega_h/omega_h_field2.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ class OmegaHField2 : public FieldT<Real>
Omega_h::Mesh& mesh_;
std::unique_ptr<MeshFieldBackend> mesh_field_;
GridPointSearch search_;
Kokkos::View<Real*> dof_holder_data_;
Kokkos::View<Real*, HostMemorySpace> dof_holder_data_;
};

} // namespace pcms
Expand Down
Loading