Skip to content

Conversation

@tomeravgil
Copy link

No description provided.

@cwsmith
Copy link
Contributor

cwsmith commented Nov 17, 2023

@tomeravgil Please rebase this branch on cws/pumipicDps, or merge cws/pumipicDps into this branch, to resolve the merge conflicts. Also, please provide (1) a name for the PR that isn't just the branch name and (2) a brief description/summary of the PR.

Copy link

@onkarsahni onkarsahni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RPIFisherman: Yang, please look into this and make changes.
@tomeravgil: Tomer, Yang will help me finish this off.

Copy link
Contributor

@RPIFisherman RPIFisherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need changes and resolving conflicts. I will solve this, no worries.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove personal attribute files, and put this in .gitignore

int nElms = p_mesh->getNumElements();
return nElms;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty lines

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this .mod file.

zArray[i] = h_centersArray(i,2);
}
}
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't need the code, please remove it.

void polympo_setMeshVtxCoords(MPMesh_ptr p_mpmesh, int nCells, double* xArray, double* yArray, double* zArray);
void polympo_getMeshVtxCoords(MPMesh_ptr p_mpmesh, int nCells, double* xArray, double* yArray, double* zArray);
//void polympo_setMeshCellCenters(MPMesh_ptr p_mpmesh, int nCenters, double* xArray, double* yArray, double* zArray);
//void polympo_getMeshCellCenters(MPMesh_ptr p_mpmesh, int nCenters, double* xArray, double* yArray, double* zArray);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented-out code.

! integer(c_int), value :: nVertices
! type(c_ptr), value :: xArray, yArray, zArray
!end subroutine
!---------------------------------------------------------------------------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented-out code.

IntElm2ElmView getElm2ElmConn() { return elm2ElmConn_; }
template<MeshFieldIndex index> auto getMeshField();
void setMeshVtxBasedFieldSize();

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the empty line.

xVertex, yVertex, zVertex, &
verticesOnCell, cellsOnCell)
verticesOnCell, cellsOnCell)!,&
!cellCenters)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented-out code.

! write(0, *) trim(nf90_strerror(status))
! stop
!end if

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented-out code.

@onkarsahni
Copy link

These features (e.g., cell centers) were taken care of in PR #67 and PR #68.

@onkarsahni onkarsahni closed this Nov 14, 2024
@onkarsahni onkarsahni deleted the ta/MPASCellCenters branch November 14, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants