Try to make the Windows Docbook tests pass#4697
Merged
bdbaddog merged 2 commits intoSCons:masterfrom Mar 12, 2025
Merged
Conversation
mwichmann
added
the
testsuite
Try to fix Windows fails on Docbook tests in case xsltproc is found. On both GitHub Actions and AppVeyor, it's found as part of StrawberryPerl, which is part of the default install. Intermittent fails seem caused by network issues (whether actual problems, or forced revectoring to https not supported by xsltproc according to some internet issue reports), so propagate two xsltproc flags for this that were in three of the "live" (named "cmd" here) tests, but not the others. Also made other parts of the setup of these tests more consistent (passing found xsltproc wasn't done) Signed-off-by: Mats Wichmann <mats@linux.com>
mwichmann
force-pushed
the
fix/win-docbook
branch
from
7d9d54f to
c9e65f5
Compare
mwichmann
changed the title
Signed-off-by: Mats Wichmann <mats@linux.com>
mwichmann
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to fix Windows fails on Docbook tests in case
xsltprocis found. On both GitHub Actions and AppVeyor, it's found as part of StrawberryPerl, which is part of the default install. Intermittent fails seem caused by network issues (whether actual problems, or forced revectoring to https not supported byxsltprocaccording to some internet issue reports), so propagate twoxsltprocflags for this that were in three of the "live" (named "cmd" here) tests, but not the others. Also made other parts of the setup of these tests more consistent (passing foundxsltprocwasn't always done)Note we don't 100% know why these 1-3 tests started failing, it's not due to an SCons change, might be due to a change to xsltproc in Strawberry, but it's not a brand-new version. However the cleanup doesn't seem like a terrible idea anyway.
Except for minor reformatting in the docbook tool, this is test only changes.
Contributor Checklist:
CHANGES.txtandRELEASE.txt(and read theREADME.rst).