Switch to using Python ternary op#4709
Merged
bdbaddog merged 1 commit intoSCons:masterfrom Apr 11, 2025
Merged
Conversation
Python 2.5 introduced a better approach than "c and x or y" which is less error-prone, and, these days, more familiar to readers. Signed-off-by: Mats Wichmann <mats@linux.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 2.5 introduced a better approach than
c and x or ywhich is less error-prone, and, these days, and presumably more familiar to readers, as for the last 20 years Python programmers probably won't have been taught the and/or form.For the most part this is behind the scenes - tools, tests, framework. It rises to visibility if someone looks hard at a few construction variables which now use the new form:
_SHLIBVERSION,PCHPDBFLAGS,CCPDBFLAGS. There is no behavioral change even in those cases.Contributor Checklist:
CHANGES.txtandRELEASE.txt(and read theREADME.rst).