Skip to content

Clean up the C/C++ compiler variable tests#4711

Merged
bdbaddog merged 2 commits intoSCons:masterfrom
mwichmann:test/cc-vars-live
Apr 11, 2025
Merged

Clean up the C/C++ compiler variable tests#4711
bdbaddog merged 2 commits intoSCons:masterfrom
mwichmann:test/cc-vars-live

Conversation

@mwichmann
Copy link
Collaborator

@mwichmann mwichmann commented Apr 10, 2025

Tests now don't combine flags-only cases (don't use a real compiler) with live cases (do require a compiler) in the same test file.

This differs from #4693 as that one worked on *FLAGS variables, this one works on the variables naming the compilers (CC, CXX and shared-lib variants).

This is a test-only change, no doc impacts.

Contributor Checklist:

  • I have created a new test or updated the unit tests to cover the new/changed functionality.
  • I have updated CHANGES.txt and RELEASE.txt (and read the README.rst).
  • I have updated the appropriate documentation

Tests now don't combine flags-only cases (don't use a real compiler)
with live cases (do require a compiler) in the same test file.

Signed-off-by: Mats Wichmann <mats@linux.com>
@mwichmann mwichmann added the testsuite Things that only affect the SCons testing. Do not use just because a PR has tests. label Apr 10, 2025
@mwichmann mwichmann added this to 4.10 Apr 10, 2025
@mwichmann mwichmann moved this to In review in 4.10 Apr 10, 2025
@bdbaddog bdbaddog merged commit 34faf1b into SCons:master Apr 11, 2025
6 of 8 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in 4.10 Apr 11, 2025
@mwichmann mwichmann added this to the NextRelease milestone Apr 12, 2025
@mwichmann mwichmann deleted the test/cc-vars-live branch April 12, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testsuite Things that only affect the SCons testing. Do not use just because a PR has tests.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants