Switch TestSCons from profile to cProfile #4774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests were failing on Python 3.15alpha due to a deprecation warning for the profile module. Signed-off-by: Mats Wichmann <[email protected]>
mwichmann
added
the
testsuite
bdbaddog
reviewed
Oct 17, 2025
testing/framework/TestSCons_time.py
Outdated
| import cProfile | ||
| try: dispatch = profile.Profile.dispatch | ||
| try: dispatch = cProfile.Profile.dispatch |
Contributor
There was a problem hiding this comment.
Is this necessary any more? isn't it now guaranteed to be present?
Collaborator
Author
There was a problem hiding this comment.
no idea, I just renamed to solve the existing problem.
Spelunking: trace_dispatch_return is not a documented method of the Profile class, though it's present. And dispatch does not seem to exist even in the pure-python profile, so I guess we just get the pass every time. Just drop that stanza?
Contributor
There was a problem hiding this comment.
I'd remove it and let CI try on many versions and see what happens?
Signed-off-by: Mats Wichmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were failing on Python 3.15alpha due to a deprecation warning for the profile module.
This is a test-only change.
Contributor Checklist:
CHANGES.txtandRELEASE.txt(and read theREADME.rst).