Use "in" and "not in" instead of ".find()" #4782
Merged
+150
−154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A maintenance edit: most instances of str.find() used for membership
checks like "if foo.find('bar') != -1" are replaced with "in" or "not in",
or in a few cases, with the "startswith()" method. The vendored docbook
utilities were not changed in this round though they had a couple of these.
Signed-off-by: Mats Wichmann <[email protected]>
Signed-off-by: Mats Wichmann <[email protected]>
Contributor
|
Have you done (or do we know) any performance testing on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A maintenance edit: most instances of
str.find()used for membership checks likeif foo.find('bar') != -1are replaced withinornot in, or in a few cases, with thestartswith()method. The vendored docbook utilities were not changed in this round though they had a couple of these.This is all-internal, no behavioral changes, so no doc impacts.
Contributor Checklist:
CHANGES.txtandRELEASE.txt(and read theREADME.rst).