Make XMILE operator parsing case-insensitive#464
Merged
enekomartinmartinez merged 4 commits intoSDXorg:devfrom Mar 14, 2025
Merged
Make XMILE operator parsing case-insensitive#464enekomartinmartinez merged 4 commits intoSDXorg:devfrom
enekomartinmartinez merged 4 commits intoSDXorg:devfrom
Conversation
Collaborator
|
Hi @benslavin Thanks for the contribution! And sorry for the delay in answering, I have limited time to dedicate to PySD now and sometimes I take more time than I would like. I have accepted your changes to the test-models repo. Could you please locally switch the subfolder to main, pull the changes and commit the new version of test-models in this PR? |
Contributor
Author
|
No worries on the delay. I appreciate you staying involved! Thanks for merging the test. I've updated the submodule ref and pushed to the PR, so it should be ready for your review. |
enekomartinmartinez
pushed a commit
that referenced
this pull request
Mar 23, 2025
* Make XMILE operator parsing case-insensitive * Updating What's New and bumping version. * Update submodule test-models to SDXorg/test-models@21aab02 (latest)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates parsing of XMILE documents to support operators regardless of case. This is in accordance with the spec.
Prior to this update, only lowercase operators ("and" and "or" specifically) were supported via the translator.
Note that this PR depends on a new test case added to the SDXorg/test-models repo.
Related issues
Type of change
PR verification (to be filled by reviewers)
If new features have been added, they have been properly documented