[envelope lib] Avoid issue with converting very large data delay to integer#50
Open
FMassin wants to merge 2 commits intoSED-EEW:masterfrom
Open
[envelope lib] Avoid issue with converting very large data delay to integer#50FMassin wants to merge 2 commits intoSED-EEW:masterfrom
FMassin wants to merge 2 commits intoSED-EEW:masterfrom
Conversation
FMassin
changed the title
FMassin
force-pushed
the
master
branch
2 times, most recently
from
edf99ac to
241186f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is adding a catch statement in the envelope buffer time limit update method in order to avoid a crash in case the delay between the current time and record start time cannot be converted implicitly to a double, which seems to happen when the delays reach enormous values (over 1 billion second).
This requires to be heavily tested before integration.