[sceewlog] config parameters update

[Thom-P]

• changed the typeThresh parameter name to magThres for consistency and understandability
• removed parameter "oldformat" from FCM config (left legacy code in case)

@FMassin and @billyburgoa, this follows our discussion during one of the session at NIEP(?). Billy, feel free to fully remove oldformat legacy code if we don't plan to use it any longer. Cheers

[FMassin]

Hello!

I think the code supporting old format could be removed too, because backward compatibility is already broken with the magThres parameter name change.

The change must also be updated with desc of change! The PR template should remind the PR author to do that, did it work?

Cheers

Fred

[FMassin]

No the reminder about the chnagelog was in the repo discussion, not in the template. That is fixed now.

[Thom-P]

Maybe we could automate the changelog update? In the end end, the changes should be clearly described in the commits themselves or the PR description.

[Thom-P]

I deleted the legacy code. @billyburgoa, can you check if that looks correct before I merge? Thanks!