[Frontend] - Not all students need to be assigned to an assignment#633
Merged
thomasdejaeghere merged 7 commits intodevelopmentfrom May 20, 2025
Merged
[Frontend] - Not all students need to be assigned to an assignment#633thomasdejaeghere merged 7 commits intodevelopmentfrom
thomasdejaeghere merged 7 commits intodevelopmentfrom
Conversation
brentjan
requested review from
LambrechtMaarten,
bramcomyn,
lennertdr and
thomasdejaeghere
| // width: inherit; | ||
| // padding-left: 10%; | ||
| // } | ||
|
|
Contributor
There was a problem hiding this comment.
@lennertdr does this break the responsivity that you put up last night?
Contributor
There was a problem hiding this comment.
Nope its alright, responsive part lies in the media query
thomasdejaeghere
approved these changes
May 20, 2025
bramcomyn
approved these changes
May 20, 2025
lennertdr
reviewed
May 20, 2025
frontend/src/app/components/create-group/create-group.component.ts
Outdated
Show resolved
Hide resolved
lennertdr
reviewed
May 20, 2025
|
|
||
| accepted$.subscribe((response) => { | ||
| if(response) this.openSnackBar(this.acceptedMessage); | ||
| if (response) this.openSnackBar(this.acceptedMessage); |
bramcomyn
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed such that there is no need for all students of a class to be divided into groups for an assignment, the members left in the members list aren't assigned to the assignment.
edit
fixed restrictions on assignment creation (you need students) and allowed >0 members in the assignment
create.flow.mp4