Skip to content

[Frontend] - Fix assignment dates #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomasdejaeghere merged 1 commit into from
May 20, 2025
Merged

[Frontend] - Fix assignment dates #634

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions frontend/src/app/components/create-assignment/create-assignment.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ export class CreateAssignmentComponent implements OnInit {

create(): void {
const newAssignment: NewAssignment | null = this.extractFormValues();

if (newAssignment) {
this.assignmentService.createAssignment(newAssignment).subscribe((response) => {

Expand Down Expand Up @@ -131,11 +130,26 @@ export class CreateAssignmentComponent implements OnInit {
const extraInstructions = this.createForm.get('extraInstructions')?.value;

if (classId && startDate && deadline) {
// Make this safe date so converting to UTC doesn't change the day
// This can be done in a beter way and should be done in the future, but for now this fix works
const safeStart = new Date(
startDate.getFullYear(),
startDate.getMonth(),
startDate.getDate(),
12, 0, 0
);

const safeDeadline = new Date(
deadline.getFullYear(),
deadline.getMonth(),
deadline.getDate(),
12, 0, 0
);
return {
classId,
learningPathId: this.learningPathId,
startDate,
deadline,
startDate: safeStart,
deadline: safeDeadline,
extraInstructions,
name
};
Expand Down