userdomain: Remove permissions from unprivileged user #1068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am using userdom_unpriv_user_template() to create an unprivileged user. That user was getting capabilities for chown, fowner and setgid. Unrpivileged users were also allowed process ptrace, which I moved into userdom_admin_user_template(). After dropping these permissions, those users were still able to login to the console and GUI (lightdm/icewm - on RHEL9) Note that this does not affect admin users - which get the capabilities in userdom_admin_user_template() Signed-off-by: Dave Sugar <dsugar100@gmail.com>
Contributor
Author
|
This change is to a bit of policy that has been around for a very long time. While I did a bit of testing, I clearly could be missing something that this is needed for. I would really appreciate any feedback on what this might be needed for. I'm also looking at other places unprivileged users get process ptrace - I will make separate pull requests as I test things. |
Member
|
I'm ok with this change but will keep open for further comment. |
Contributor
Author
|
Thanks - yes, let's give it a few days for comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using userdom_unpriv_user_template() to create an unprivileged user. That user was getting capabilities for chown, fowner and setgid. Unrpivileged users were also allowed process ptrace, which I moved into
userdom_admin_user_template().
After dropping these permissions, those users were still able to login to the console and GUI (lightdm/icewm - on RHEL9)
Note that this does not affect admin users - which get the capabilities in userdom_admin_user_template()