Potential fix for code scanning alert no. 16: Shell command built from environment values #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/SFARPak/ACode/security/code-scanning/16
To fix the issue, avoid constructing the
attribshell command by string interpolation and passing it toexecSync, which will spawn a subshell and allow possible injection via the interpolated path.Instead, invoke the
attrib.execommand directly with its arguments usingexecFileSync, passing the arguments as an array so that no shell interpretation occurs. This avoids special character problems and command injection risks. Specifically, inrmDir, replace:with:
Additionally, import
execFileSyncfromchild_processat the top of the file.Suggested fixes powered by Copilot Autofix. Review carefully before merging.