Conversation
There was a problem hiding this comment.
This looks really good. I'll just add a quick remark that PR #31 changes the way we initialize our models from taking a in_channels: int to a input_shape: tuple[int, int, int], representing a single image with dimensions [channel, height, width].
I think it makes sense to accept your current model, then you can modify it later in PR #31 like Jan, I and soon Johan have.
There was a problem hiding this comment.
Thanks a lot for the reminder. I will change my model initialization and adjust it accordingly before merging
|
Also you should try to format your code again with |
|
I didn't know about isort but thanks for the tip I will format it properly. |
|
Now the files are properly formatted and the model is updated. |
|
Nice work! |
Moved my metric test function into the test directory. Updated the load files with my classes. Updated the choices in the main file.