Update Network module code #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99 tasks
ChrisThrasher
requested changes
Jan 12, 2025
ChrisThrasher
force-pushed
the
network
branch
from
0601ee3 to
3d32107
Compare
Marioalexsan
force-pushed
the
network
branch
2 times, most recently
from
6d37faf to
8a374ef
Compare
ChrisThrasher
approved these changes
Jan 13, 2025
ChrisThrasher
force-pushed
the
network
branch
from
8a374ef to
f5eab8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be the last changes needed to align CSFML and SFML, theoretically.
I changed the representation of
sfIpAddress_Noneso that it is distinct fromsfIpAddress_Anyand actually represents an invalid / empty address, i.e. all bytes set to 0. Not 100% sure if this is meaningful or if it changes any behaviour in the code.