Skip to content

Fix symbol export/import on windows #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lapinozz merged 4 commits into from
Apr 4, 2026
+4 −8
Merged

Fix symbol export/import on windows #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4640d6d
fix symbol export/import on windows
lapinozz Jan 30, 2026
c07e607
Combine compile definitions in one declaration
lapinozz Feb 1, 2026
c24c224
removed deprecated compiler support
lapinozz Feb 1, 2026
c406725
Removed check for deprecated compiler support
lapinozz Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ if(WIN32 AND MINGW)
target_link_libraries(ImGui-SFML PUBLIC imm32)
endif()
if(BUILD_SHARED_LIBS)
target_compile_definitions(ImGui-SFML PRIVATE IMGUI_SFML_SHARED_LIB)
set_target_properties(ImGui-SFML PROPERTIES DEFINE_SYMBOL "IMGUI_SFML_EXPORTS")
target_compile_definitions(ImGui-SFML PUBLIC IMGUI_SFML_SHARED_LIB
PRIVATE IMGUI_SFML_EXPORTS)
set_target_properties(ImGui-SFML PROPERTIES DEBUG_POSTFIX "_d")
endif()
if(IMGUI_SFML_DISABLE_OBSOLETE_FUNCTIONS)
Expand Down
8 changes: 2 additions & 6 deletions imgui-SFML_export.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,17 @@
#if _WIN32
#ifdef IMGUI_SFML_EXPORTS
#define IMGUI_SFML_API __declspec(dllexport)
#define IMGUI_API __declspec(dllexport)
#else
#define IMGUI_SFML_API __declspec(dllimport)
#define IMGUI_API __declspec(dllexport)
#endif
#elif __GNUC__ >= 4
#elif __GNUC__
#define IMGUI_SFML_API __attribute__((visibility("default")))
#define IMGUI_API __attribute__((visibility("default")))
#else
#define IMGUI_SFML_API
#define IMGUI_API
#endif
#else
#define IMGUI_SFML_API
#define IMGUI_API
#endif

#define IMGUI_API IMGUI_SFML_API
#endif