-
-
Notifications
You must be signed in to change notification settings - Fork 1
change project structure to mono-repo with multiple packages #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7ec514f to
a6218db
Compare
a6218db to
efc39ad
Compare
TheJJ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking great so far!
Apparently it's a pain to get mypy to work properly with multiple namespace packages in a single repo -> ty just works (tm) and can be integrated into the pre-commit hooks since its fast enough.
TheJJ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some ideas for improvements
c0424d2 to
39a3854
Compare
TheJJ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wie schön
TODO:
_versionfile into common package and only having it there