add support for Intel XPU platform#280
Conversation
Signed-off-by: Liu, Kaixuan <kaixuan.liu@intel.com>
|
@alihassanijr @lartpang , Hi, we are from Intel and want to add Intel XPU platform support for this project. Can you help review this PR? Many thanks!! |
|
@alihassanijr @lartpang , for more context, Intel XPU(which is Intel's GPU) is a built-in device of PyTorch since PyTorch 2.5 and with Flex Attention also enabled and validated. So, we'd like to enable |
|
Thank you for your contribution. Could you please confirm if you've also run the Flex unit tests on XPU? Could you also share the version of torch you're using? If xpu support in Flex was added in a specific version we'd want to guard against it. |
Sure. @kaixuanliu pls run flex-atten related UT on XPU and report results here, and pls add version guard for flex attention. |
|
Hi @alihassanijr , I can run Flex unit tests successfully on XPU w/ adjustment in L125-L126, I need to change |
Signed-off-by: Liu, Kaixuan <kaixuan.liu@intel.com>
|
@alihassanijr , could you pls take a second look? Thx very much |
|
@yao-matrix @kaixuanliu apologies for the delay. It looks like you're testing the flex backend against itself if you changed only those lines. The only alternative I can think of, since our reference is also in CUDA C++, is to test flex XPU against flex CPU, and that might require some additional work in the test suite. Could you take a shot at that and push the tests as well? Also, feel free to make a separate test for just xpu like |
Signed-off-by: Liu, Kaixuan <kaixuan.liu@intel.com>
…to xpu-support
|
@alihassanijr Thx! Compare with flex-fna CPU version is a good advice, I have updated the testing part following your suggestion, and tests passed in my environment. Pls have a review again. |
Signed-off-by: Liu, Kaixuan <kaixuan.liu@intel.com>
|
@alihassanijr , happy new year, could you help take a second look at this PR? Thx very much. |
|
@kaixuanliu , could you pls rebase the PR? Thx. |
Signed-off-by: Liu, Kaixuan <kaixuan.liu@intel.com>
|
Sure, have done. |
|
@alihassanijr , could you help take a second look? Thx very much. |
1 similar comment
|
@alihassanijr , could you help take a second look? Thx very much. |
No description provided.