Open
Conversation
Member
|
Hey @lundstrom14 thanks for the patch! i'd love to port to the new stdlib APIs tho it would be suuuper great if we could get CI also demonstrating that it works before we start landing changes like this 🙏🏼 Do you have any interest in maybe helping with that as well? If so i think there should already be some open issues/prs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify
PopenRunnerto use selectors module for cross-platform compatibilityThis change replaces the Linux-specific
select.epollwith the selectors module, allowing the code to work on other platforms. Key updates include usingselectors.DefaultSelector()and handling events withselectors.EVENT_READfor better portability