Replace NaturalLanguagePlaceNameStructure as type of origin and destination elements#176
Merged
haeckerbaer merged 4 commits intointegrationfrom Oct 27, 2025
Conversation
NaturalLanguagePlaceNameStructure is replaced with NaturalLanguageStringStructure to support commas that are very common in stop names
haeckerbaer
requested review from
Aurige,
DohmenClaus,
TuThoThai,
skinkie,
tim-rivett and
ue71603
skinkie
approved these changes
Sep 23, 2025
TuThoThai
approved these changes
Sep 24, 2025
ue71603
approved these changes
Sep 24, 2025
TuThoThai
added
Needs CEN documentation Update
TuThoThai
deleted the
replace-string-type-of-origin-destination-elements
branch
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NaturalLanguagePlaceNameStructure is too restrictive and therefore not usable in regions where stop names often contain commas. Also, in some instances the same or similar elements in other service specifications already uses a different type NaturalLanguageStringStructure which is conflicting.
The pull request aimes to harmonize all of these related elements for declaration of origin/destination and extends the allowed characters accordingly.
Alternatively, or additionally, an update of the underlying PopulatedStringType is proposed (to remove comma in the pattern restriction):
<xsd:restriction base="PopulatedStringType"><xsd:pattern value="[^\[\]\{\}\?$%\^=@#;:]+"/></xsd:restriction>