Skip to content

add new value to ServiceConditionEnumeration #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
haeckerbaer wants to merge 3 commits into
base: v2.3-wip
Choose a base branch
from
Open

add new value to ServiceConditionEnumeration #193

haeckerbaer wants to merge 3 commits into from

Conversation

@haeckerbaer
Copy link
Collaborator

@haeckerbaer haeckerbaer commented Dec 3, 2025

Currently there's no appropriate value for Condition (within PtSituationElement.Consequence as part of an SX message) in case the AccessibilityAssessment, for example of an AffectedStopPoint, is updated as a consequence of a situation.

@haeckerbaer haeckerbaer added this to the v2.3 milestone Dec 3, 2025
@haeckerbaer haeckerbaer self-assigned this Dec 3, 2025
@haeckerbaer haeckerbaer added enhancement New feature or request SX For everything SIRI-SX Needs CEN documentation Update These require CEN documentation update to match XSD & examples labels Dec 3, 2025
@TuThoThai TuThoThai changed the base branch from integration to 2.3 December 9, 2025 12:07
@TuThoThai TuThoThai changed the base branch from 2.3 to integration December 9, 2025 12:07
@haeckerbaer haeckerbaer changed the base branch from integration to 2.3 December 19, 2025 11:32
@TuThoThai
Correction of the annotation
c8fee98 
* Clarification of the annotation
* Adding '+v2.3' to identify that it is a new value
@Aurige
Copy link
Contributor

Aurige commented Jan 28, 2026

in SIRI FM, we have a more detailed description:
image
This allows to make the difference in the consequences for mobility Impaired (as in this proposal) but also for other disabilities (visual, auditory, etc.).
I'm Ok with this PR, but want to raise the discussion to check if we shouldn't extend it

@TuThoThai TuThoThai mentioned this pull request Jan 28, 2026
Open
TuThoThai
TuThoThai approved these changes Jan 28, 2026
View reviewed changes
Copy link
Collaborator

@TuThoThai TuThoThai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with the discussion on extending the enumeration started in #201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TuThoThai TuThoThai TuThoThai approved these changes

@skinkie skinkie Awaiting requested review from skinkie

@Aurige Aurige Awaiting requested review from Aurige

@ue71603 ue71603 Awaiting requested review from ue71603

@tim-rivett tim-rivett Awaiting requested review from tim-rivett

@Ulf9 Ulf9 Awaiting requested review from Ulf9

@SteffenSuhr SteffenSuhr Awaiting requested review from SteffenSuhr

At least 2 approving reviews are required to merge this pull request.

Assignees

@haeckerbaer haeckerbaer

Labels

enhancement New feature or request Needs CEN documentation Update These require CEN documentation update to match XSD & examples SX For everything SIRI-SX

Projects

None yet

Milestone

v2.3

Development

Successfully merging this pull request may close these issues.

3 participants

@haeckerbaer @Aurige @TuThoThai