add missing element StopPlaceName to AffectedStopPlaceStructure in SX #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haeckerbaer
requested review from
Aurige,
BredeD,
SteffenSuhr,
TuThoThai,
Ulf9,
skinkie and
tim-rivett
Contributor
|
Breaking change? |
Aurige
previously approved these changes
Jan 28, 2026
ue71603
previously approved these changes
Jan 28, 2026
tim-rivett
previously approved these changes
Jan 28, 2026
* Clarification that it is the for the STOP PLACE affected by the SITUATION * Added '+v2.3'
TuThoThai
dismissed stale reviews from tim-rivett, ue71603, and Aurige
via
a14813a
TuThoThai
approved these changes
Jan 28, 2026
Collaborator
TuThoThai
left a comment
TuThoThai
left a comment
There was a problem hiding this comment.
Approved as it is an addition of an element. It should not create a breaking change
ue71603
approved these changes
Jan 28, 2026
Collaborator
Author
Hello @skinkie, can you elaborate on how it is breaking? There's a new optional element and an annotation update of a still existing element. The latter might be interpreted as a kind of "soft" breaking, is that the issue? However, i don't see any issues in keep on using the PlaceName for the stop place name (instead of the new element). |
Collaborator
|
In my opinion, this is simply a missing element that was overlooked in the original implementation. It makes no sense to give stopPoint a name and not stopPlace. Especially since there is usually no explicit naming of stopPoint as a platform. |
SteffenSuhr
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title suggests. In AffectedStopPoint there is StopPlaceRef, the corresponding StopPlaceName and also PlaceRef and corresponding PlaceName (in addition to StopPointRef/-Name). However, in AffectedStopPlace there is only PlaceName which generated some confusion on UmS side (VDV736 profile). We propose to add the optional element StopPlaceName (as known in other affects structures) so that there's a cleaner "link" between ref and name.