Skip to content

fix: update clientbound packet listener retrieval to use packetClass #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twisti-dev merged 1 commit into from
Apr 14, 2025
Merged

fix: update clientbound packet listener retrieval to use packetClass #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ javaVersion=21
mcVersion=1.21.4

group=dev.slne.surf
version=1.21.4-2.13.0-SNAPSHOT
version=1.21.4-2.13.1-SNAPSHOT
relocationPrefix=dev.slne.surf.surfapi.libs
3 changes: 1 addition & 2 deletions ...r/src/main/kotlin/dev/slne/surf/surfapi/bukkit/server/impl/nms/SurfBukkitNmsBridgeImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import dev.slne.surf.surfapi.bukkit.api.nms.listener.NmsServerboundPacketListene
import dev.slne.surf.surfapi.bukkit.api.nms.listener.packets.clientbound.NmsClientboundPacket
import dev.slne.surf.surfapi.bukkit.api.nms.listener.packets.serverbound.NmsServerboundPacket
import dev.slne.surf.surfapi.bukkit.api.packet.listener.listener.PacketListenerResult
import dev.slne.surf.surfapi.bukkit.server.impl.nms.listener.packets.NmsPacketImpl
import dev.slne.surf.surfapi.core.api.util.*
import it.unimi.dsi.fastutil.objects.ObjectSet
import org.bukkit.entity.Player
Expand Down Expand Up @@ -94,7 +93,7 @@ class SurfBukkitNmsBridgeImpl : SurfBukkitNmsBridge {
packet: Packet,
player: Player,
): Packet? {
val listeners = clientboundPacketListeners[NmsPacketImpl.getFromApi(packet).nmsClass] ?: return packet
val listeners = clientboundPacketListeners[packet.packetClass] ?: return packet

if (listeners.isEmpty()) return packet

Expand Down