Add ArrayDeque rationale and nesting depth limit to deep copy

[Copilot]

• Understand the feedback from the review comment
• Add documentation explaining why ArrayDeque is used instead of Stack
• Add a size limit check (MAX_NESTING_DEPTH = 512) to prevent memory issues with extremely large nested structures
• Test the changes to ensure they work correctly
• Reply to the comment once changes are complete
• Update branch with latest changes from feat/ppdc-view

Changes Made

1. Added comprehensive documentation explaining why ArrayDeque is preferred over Stack:

   • ArrayDeque is not synchronized, making it faster for single-threaded use
   • Stack extends Vector, which has legacy synchronization overhead
   • ArrayDeque is the recommended implementation for stack operations in modern Java/Kotlin

2. Added nesting depth limit check:

   • Introduced MAX_NESTING_DEPTH constant set to 512
   • Added runtime check during deep copy to prevent memory exhaustion
   • Throws IllegalStateException with clear error message when limit is exceeded

3. Updated branch with latest changes:

   • Merged latest commits from feat/ppdc-view base branch
   • Includes fixes for snapshot logic and read lock handling

These changes address the code review feedback about documenting the use of ArrayDeque and protecting against memory issues from extremely large nested structures.

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• repo.slne.dev
  • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED -Xmx4G -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-8.14.3-bin/cv11ve7ro1n3o1j4so8xd9n66/gradle-8.14.3/lib/gradle-daemon-main-8.14.3.jar -javaagent:/home/REDACTED/.gradle/wrapper/dists/gradle-8.14.3-bin/cv11ve7ro1n3o1j4so8xd9n66/gradle-8.14.3/lib/agents/gradle-instrumentation-agent-8.14.3.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 8.14.3 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[twisti-dev]

@copilot update branch

[Copilot]

@copilot update branch

Branch updated with latest changes from feat/ppdc-view in commit 71297ee. The merge was successful with no conflicts.

[github-actions]

Qodana for JVM

1 new problem were found

Inspection name	Severity	Problems
Unresolved reference in KDoc	🔶 Warning	1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions