This repository was archived by the owner on Dec 10, 2025. It is now read-only.
refactor: simplify Netty listener registration and update NettyPacket… #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
surf-cloud-apiandsurf-cloud-coreprojects, focusing on simplifying annotations, improving data classes, and cleaning up imports and coroutine usage. Below are the most important changes:Simplification of Annotations:
SurfNettyPacketHandlerannotation class insurf-cloud-api-common.api.SurfNettyPacketHandlerannotation by removingAliasForandKClassimports and their associated properties inSurfNettyPacketHandler.kt. [1] [2]Data Class Improvements:
NettyPacketInfofrom a value class to a data class to improve data handling and provide additional functionality inNettyPacketInfo.kt.Import Cleanup:
NettyListenerRegistry.ktto streamline the file.RegisteredListener.ktto remove unnecessary dependencies.Coroutine Usage:
handlemethod ofRegisteredListenerby removingwithContext(Dispatchers.IO)and directly handling the invoker type. [1] [2]