-
Notifications
You must be signed in to change notification settings - Fork 0
Add and Enhance Network Commands for Player Management #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 62 out of 62 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
surf-cloud-bukkit/src/main/kotlin/dev/slne/surf/cloud/bukkit/command/connection/SilentDisconnectPlayerCommand.kt:11
- [nitpick] Consider finalizing the command name and updating the TODO comment to reflect a clear and consistent naming convention.
fun silentDisconnectPlayerCommand() = commandTree("silentdisconnect") { // TODO: 13.04.2025 14:15 - better name
surf-cloud-bukkit/src/main/kotlin/dev/slne/surf/cloud/bukkit/command/connection/DisconnectPlayerCommand.kt:37
- [nitpick] Consider revising the disconnect error message to use a more standardized and professional tone similar to other system messages.
error("DU WURDEST VOM NETZWERK GEWORFEN")
|
Closes #22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 62 out of 62 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
surf-cloud-bukkit/src/main/kotlin/dev/slne/surf/cloud/bukkit/command/connection/DisconnectPlayerCommand.kt:35
- [nitpick] The local variable 'reason' shadows the function parameter 'reason'. Consider renaming one of them for clarity, e.g., using 'finalReason' for the local variable.
val reason = reason ?: buildText {
surf-cloud-bukkit/src/main/kotlin/dev/slne/surf/cloud/bukkit/BukkitMain.kt:50
- The variable 't' is used for error handling here without being defined in this context, which will cause a runtime error. Ensure that the proper exception variable is captured or remove this erroneous reference.
t.handleEventuallyFatalError { Bukkit.shutdown() }
This pull request introduces/refactors commands and APIs to improve player management:
Find Command
/find <player>).Send Command
/send player <player> toServer <server>, etc.).Server Command
/server <server>).Last Seen & Playtime
/lastseen <player>shows the time a player was last online./playtime [player]shows total and per-server group playtime.How to Use
/find <player>– locate player; optional click-to-teleport./send [player|all|current|server|group] [...]– move players to target server/group./server <server>– connect to a server if authorized./lastseen <player>and/playtime [player]– display offline info.PR merges quickly manage players across the network.