Skip to content

Use random skynormals for vertex and ambient lighting. Also replaced -lightprobelevel with -lightprobesamples#255

Merged
SNMetamorph merged 10 commits intoSNMetamorph:masterfrom
ncuxonaT:patch-13
Nov 7, 2025
Merged

Use random skynormals for vertex and ambient lighting. Also replaced -lightprobelevel with -lightprobesamples#255
SNMetamorph merged 10 commits intoSNMetamorph:masterfrom
ncuxonaT:patch-13

Conversation

@ncuxonaT
Copy link
Contributor

@ncuxonaT ncuxonaT commented Nov 7, 2025

No description provided.

@SNMetamorph
Copy link
Owner

There is compiling error:

 /home/runner/work/PrimeXT/PrimeXT/utils/pxrad/ambientcube.cpp:265:58: error: ‘g_lightprobelevel’ was not declared in this scope; did you mean ‘g_lightprobesamples’?
   265 |         scaleAvg = 4.0f * M_PI / ((float)g_numskynormals[g_lightprobelevel] * scaleAvg);        //ratio of ray cone and face solid angles
       |                                                          ^~~~~~~~~~~~~~~~~
       |                                                          g_lightprobesamples

@ncuxonaT
Copy link
Contributor Author

ncuxonaT commented Nov 7, 2025

Да, там должно быть
scaleAvg = 4.0f * M_PI / ((float)g_lightprobesamples * scaleAvg); //ratio of ray cone and face solid angles

@SNMetamorph SNMetamorph merged commit 1c84d75 into SNMetamorph:master Nov 7, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants