Merged
Conversation
Member
Author
|
Some odd performance changes, but is hopefully noise https://rebench.dev/SOMpp/compare/3c982cb8c5fd1f408d986435c678be2a2dde3cef..dccfabcdc0acf709095b3ffa5e13622661585afe |
This needs to update the global bytecode index. I chose to do this in the reset primitive explicitly, and do not generalize this by updating the bytecode index on every primitive, to avoid overhead. Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
smarr
force-pushed
the
restore-block-restart
branch
from
dccfabc to
2049d98
Compare
Signed-off-by: Stefan Marr <git@stefan-marr.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restores the restart primitive on blocks so that
#whileTrue:and#whileFalse:work correctly for blocks that were not inlined.Issue reported by @sillycross. Thanks.
Needs SOM-st/SOM#125 to be merged to update core-lib to a merged version.