-
Notifications
You must be signed in to change notification settings - Fork 17
feat(lib-blockchain): Add DifficultyConfig struct for adaptive diffic… #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
umwelt
merged 9 commits into
development
from
626-featlib-blockchain-add-difficultyconfig-struct-to-blockchain-state
Jan 10, 2026
+388
−26
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5736c3a
feat(lib-blockchain): Add DifficultyConfig struct for adaptive diffic…
PeterGRutherford 6aae281
fix(lib-blockchain): Improve DifficultyConfig naming and add governan…
umwelt bb77c49
Merge branch 'development' into 626-featlib-blockchain-add-difficulty…
umwelt 5ecf68b
Merge branch 'development' into 626-featlib-blockchain-add-difficulty…
umwelt 914e49e
fix: Remove useless port validation on u16 type
umwelt da01af2
fix: Remove redundant DifficultyConfig re-export
umwelt 104ab69
fix: Avoid unnecessary cloning of DifficultyConfig in difficulty getter
umwelt ecce5b1
fix: Make with_params validate parameters and return Result
umwelt 6a0f2f1
refactor: Rename difficulty adjustment fields for semantic clarity
umwelt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing blockchain serialization test (test_blockchain_serialization) does not verify that the difficulty_config field is properly serialized and deserialized. Adding a blockchain field requires updating the test to verify backward compatibility and proper serialization of the new field, especially since this field is critical for governance and consensus operations.