Skip to content

Migrate last Android Tests to Unit Tests #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Migrate last Android Tests to Unit Tests #477

wants to merge 3 commits into from

Conversation

@MGaetan89
Copy link
Contributor

@MGaetan89 MGaetan89 commented Mar 19, 2024 •
edited
Loading

Pull request

Description

This PR migrates the last Android Tests (in IsPlayingAllTypeOfContentTest) to regular Unit Tests.

Note

In draft for now, because there is one case that is failing.

Changes made

  • Migrate IsPlayingAllTypeOfContentTest to use Robolectric as a regular Unit Test.
  • Remove the Android Tests step on GitHub Actions.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 added the enhancement New feature or request label Mar 19, 2024
@MGaetan89 MGaetan89 added this to the Test milestone Mar 19, 2024
@MGaetan89 MGaetan89 self-assigned this Mar 19, 2024
@MGaetan89 MGaetan89 force-pushed the migrate_last_android_test branch 4 times, most recently from f68a894 to 5c77be2 Compare April 8, 2024 09:41
@MGaetan89 MGaetan89 force-pushed the migrate_last_android_test branch 4 times, most recently from c679f09 to 4fff6bd Compare April 24, 2024 17:52
@MGaetan89 MGaetan89 force-pushed the migrate_last_android_test branch 3 times, most recently from 8081789 to baee7cc Compare May 10, 2024 09:53
@MGaetan89 MGaetan89 force-pushed the migrate_last_android_test branch from baee7cc to c5218a7 Compare May 21, 2024 07:14
@MGaetan89 MGaetan89 force-pushed the migrate_last_android_test branch 2 times, most recently from 34cbc1b to 83a10f1 Compare June 19, 2024 14:53
@MGaetan89 MGaetan89 force-pushed the migrate_last_android_test branch 2 times, most recently from f58eb65 to 535d6d9 Compare July 2, 2024 07:40
@MGaetan89 MGaetan89 force-pushed the migrate_last_android_test branch 3 times, most recently from 8a7d830 to 24ba495 Compare July 18, 2024 06:44
@MGaetan89 MGaetan89 force-pushed the migrate_last_android_test branch 2 times, most recently from 0cc820c to 7d87a1a Compare July 29, 2024 11:49
@MGaetan89 MGaetan89 force-pushed the migrate_last_android_test branch from 7d87a1a to 2063a86 Compare July 31, 2024 07:00
@MGaetan89 MGaetan89 force-pushed the migrate_last_android_test branch from 2063a86 to 90bf6df Compare August 21, 2024 18:53
@MGaetan89 MGaetan89 force-pushed the migrate_last_android_test branch from 90bf6df to 4b8310b Compare September 3, 2024 11:27
@MGaetan89 MGaetan89 force-pushed the migrate_last_android_test branch 2 times, most recently from 98fa2c9 to 36d0553 Compare September 18, 2024 12:45
@MGaetan89 MGaetan89 force-pushed the migrate_last_android_test branch from 36d0553 to dad7763 Compare September 26, 2024 15:12
@MGaetan89 MGaetan89 force-pushed the migrate_last_android_test branch 2 times, most recently from 380956a to 4e7e606 Compare October 14, 2024 09:36
@MGaetan89 MGaetan89 force-pushed the migrate_last_android_test branch from 4e7e606 to 0b34559 Compare November 19, 2024 16:04
@MGaetan89 MGaetan89 force-pushed the migrate_last_android_test branch from 0b34559 to 3e4f07a Compare December 17, 2024 09:28
@MGaetan89 MGaetan89 force-pushed the migrate_last_android_test branch from 3e4f07a to 9679045 Compare January 6, 2025 09:16
@MGaetan89 MGaetan89 force-pushed the migrate_last_android_test branch from 9679045 to 48ff974 Compare February 19, 2025 16:27
@MGaetan89 MGaetan89 force-pushed the migrate_last_android_test branch from 48ff974 to 6935cbf Compare February 19, 2025 16:32
@MGaetan89 MGaetan89 force-pushed the migrate_last_android_test branch 2 times, most recently from 093cea3 to b9c2e51 Compare May 27, 2025 13:19
@github-actions
Copy link

github-actions bot commented May 27, 2025 •
edited
Loading

Code Coverage

Overall Project 49.92% 🟢

There is no coverage information present for the Files changed

@MGaetan89 MGaetan89 force-pushed the migrate_last_android_test branch from b9c2e51 to fc405fe Compare May 27, 2025 14:40
@MGaetan89 MGaetan89 force-pushed the migrate_last_android_test branch from fc405fe to 8a0475f Compare June 26, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@MGaetan89 MGaetan89

Labels

enhancement New feature or request

Projects

Pillarbox
Status: 📋 Backlog

Milestone

Test

Development

Successfully merging this pull request may close these issues.

1 participant

@MGaetan89