fix clang error #85
Merged
fix clang error #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
to cvc5/cvc5
that referenced
this pull request
May 6, 2025
The latest release of libpoly includes fixes for building the library with recent versions of Clang (SRI-CSL/libpoly#85) and CMake (SRI-CSL/libpoly#92). This PR also removes some patches that are not longer required.
yoni206
pushed a commit
to yoni206/cvc5
that referenced
this pull request
May 28, 2025
The latest release of libpoly includes fixes for building the library with recent versions of Clang (SRI-CSL/libpoly#85) and CMake (SRI-CSL/libpoly#92). This PR also removes some patches that are not longer required.
RyanGlScott
added a commit
to GaloisInc/what4-solvers
that referenced
this pull request
Nov 10, 2025
This is primarily motivated by bringing in the changes from cvc5/cvc5#11861, which brings in a newer version of `libpoly` that is compatible with recent versions of Apple `clang++`. (See SRI-CSL/libpoly#85 for the relevant `libpoly` patch.) This, in turn, allows `libpoly` to build with `macos-15` CI runners. Note that recent versions of `cvc5` no longer require patching out the use of the `ld.gold` linker on Windows, so we can remove the corresponding `what4-solvers` patch that does this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.