Skip to content

fix: can't reach last slides #527 #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simonmerqueodev wants to merge 2 commits into
base: master
Choose a base branch
from
+20 −20
Open

fix: can't reach last slides #527 #579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18fe487
fix: can´t reach last slides #527
simonmerqueodev Aug 2, 2021
786dfa8
new version
simonmerqueodev Aug 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dist/vue-carousel.min.js
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions docs/themes/vue/source/js/vue-carousel.min.js
View file
Open in desktop

Large diffs are not rendered by default.

28 changes: 14 additions & 14 deletions src/Carousel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,20 +858,20 @@ export default {
}

// & snap the new offset on a slide or page if scrollPerPage
const width = this.scrollPerPage
? this.slideWidth * this.currentPerPage
: this.slideWidth;

// lock offset to either the nearest page, or to the last slide
const lastFullPageOffset =
width * Math.floor(this.slideCount / (this.currentPerPage - 1));
const remainderOffset =
lastFullPageOffset +
this.slideWidth * (this.slideCount % this.currentPerPage);
if (this.offset > (lastFullPageOffset + remainderOffset) / 2) {
this.offset = remainderOffset;
} else {
this.offset = width * Math.round(this.offset / width);
if (this.scrollPerPage) {
const width = this.slideWidth * this.currentPerPage;

// lock offset to either the nearest page, or to the last slide
const lastFullPageOffset =
width * Math.floor(this.slideCount / (this.currentPerPage - 1));
const remainderOffset =
lastFullPageOffset +
this.slideWidth * (this.slideCount % this.currentPerPage);
if (this.offset > (lastFullPageOffset + remainderOffset) / 2) {
this.offset = remainderOffset;
} else {
this.offset = width * Math.round(this.offset / width);
}
}

// clamp the offset between 0 -> maxOffset
Expand Down