Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I added two new props the the "Carousel" component: "endOfCarouselLink" and "beginningOfCarousel". The "endOfCarousel" prop takes a URL as an argument and redirects to that link when you try to scroll past the end of of the last slide in the carousel. Likewise, the "beginningOfCarousel" props takes a URL as an argument and redirects to that link when you try to navigate backwards when on the first slide. I modified the "advancePage" to handle the cases when you try to scroll past either end of the carousel and redirect to the appropriate link.
Motivation and Context
#294
How Has This Been Tested?
This was tested by hand using vue-play to make sure the changes work and do not break the current functionality of the carousel.
Screenshots (if appropriate):
Types of changes
Checklist: