adding enumeration system tests #8280
Open
+38
−803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors enumeration tests by removing the test_enumeration.py integration test and parameterizing several system tests in test_nss.py to run with enumeration enabled. While the refactoring of existing tests is a positive change, I have a significant concern about the removal of test_enumeration.py as it appears to result in a loss of test coverage for dynamic enumeration updates and the auto_private_groups feature. I've added a comment detailing this issue.
danlavu
added
Deferred
dependencies
Author
thalman
approved these changes
Dec 15, 2025
Contributor
thalman
left a comment
thalman
left a comment
There was a problem hiding this comment.
The change looks good.
CI issues are not related to the change, but they do not seem to be just random failure
danlavu
force-pushed
the
tests-enumeration
branch
from
b8e6573 to
93551e3
Compare
thalman
reviewed
Jan 7, 2026
added 2 commits
January 8, 2026 13:54
Reviewed-by: Jakub Vávra <[email protected]> Reviewed-by: Tomáš Halman <[email protected]>
Reviewed-by: Jakub Vávra <[email protected]> Reviewed-by: Tomáš Halman <[email protected]>
sssd-bot
force-pushed
the
tests-enumeration
branch
from
93551e3 to
bd0cbb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.